Skip to content

fix(orion): reclaim Antares overlays and reject builds under disk pressure#2150

Merged
genedna merged 6 commits into
gitmono-dev:mainfrom
benjamin-747:main
Jul 23, 2026
Merged

fix(orion): reclaim Antares overlays and reject builds under disk pressure#2150
genedna merged 6 commits into
gitmono-dev:mainfrom
benjamin-747:main

Conversation

@benjamin-747

Copy link
Copy Markdown
Collaborator

No description provided.

GET /v2/task/{cl} now returns Vec<OrionTaskDTO> (empty when none), so repeated
pushes no longer break Checks. Also document regenerating gitmono.json /
generated.ts via moon/script/gen-client, and bump tokio-stream to 0.1.19.
…ssure

Prevent long-lived VMs from filling the guest root FS (which drops
WebSocket heartbeats and marks workers Lost) by deleting upper/cl after
umount, pruning orphans on runner start, and refusing TaskBuild when
usage exceeds the reject threshold. Also raise default image_disk_gb to 50.
Proxy orion-scheduler's /logs/orion/stream through mono as admin-only SSE,
and show live provision/startup output on the Orion Clients page after Start Runner.
Holding workers.get_mut across DB awaits on retry could stall the tokio
runtime under heartbeat/health-check contention. Extract claim_worker_for_build
and cover with a concurrency regression test.
@benjamin-747
benjamin-747 requested a review from genedna July 23, 2026 03:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 998ba6a021

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread orion/src/ws.rs
Comment on lines +391 to +394
if let Err(e) = sender.send(WSMessage::TaskAck {
build_id,
success: false,
message: format!(

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Release the worker when rejecting for disk pressure

When disk pressure remains above the reject threshold, the runner now returns only TaskAck { success: false } and skips the build, but the scheduler's TaskAck handler in orion-server/src/service/ws_service.rs only logs that message and does not remove active_builds or move the worker out of Busy. In this disk-pressure path the worker keeps heartbeating while permanently busy, so even after space is freed the scheduler will not dispatch more work to it; send the normal completion message or teach the server to finalize failed acks.

Useful? React with 👍 / 👎.

@genedna
genedna added this pull request to the merge queue Jul 23, 2026
Merged via the queue into gitmono-dev:main with commit de77cbe Jul 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants