Repository navigation
chore: pin Node.js with .nvmrc - #23
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.nvmrcpinned to24.22.1(matchinggitify,website, andelectron-menubar) and switches CI from the hardcodednode-version: '26'to that file.engines.nodestays at>=24. Node 24 is the LTS line documented in CONTRIBUTING, and the CI scripts (node --check,node --test) do not rely on Node 26 features. Renovate now tracks one Node pin (.nvmrc) instead of a literal in the workflow..nvmrc:24.22.1.github/workflows/ci.yml:node-version: '26'→node-version-file: .nvmrcVerification
npm testandnpm run bundlelocally on Node 24.22.1