fix(tests): don't run PowerShell tests via WSL-interop powershell.exe#2971
Open
lissy93 wants to merge 2 commits into
Open
fix(tests): don't run PowerShell tests via WSL-interop powershell.exe#2971lissy93 wants to merge 2 commits into
lissy93 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates PowerShell detection in test fixtures to treat powershell(.exe) as Windows-only, avoiding non-Windows environments accidentally selecting Windows PowerShell.
Changes:
- Gate
_POWERSHELLdiscovery behindos.name == "nt"in multiple tests. - Normalize the detection expression with explicit parentheses for readability.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_setup_tasks.py | Restricts _POWERSHELL detection to Windows. |
| tests/test_setup_plan_no_overwrite.py | Restricts _POWERSHELL detection to Windows. |
| tests/test_setup_plan_feature_json.py | Restricts _POWERSHELL detection to Windows. |
| tests/test_check_prerequisites_paths_only.py | Restricts _POWERSHELL detection to Windows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Windows PowerShell versus a user installed PowerShell is probably how we should differentiate and then make sure it works properly. Please address Copilot feedback in that light |
Author
|
Thanks @mnriem - done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes tests for WSL.
Previously, tests were failing when running from within WSL. Because the script was checking if Powershell is within the path then running the PS1 fixtures if found, else skipping.
However, on WSL powershell.exe IS in the path, however Linux can't execute the powershell scripts.
This change just adds
if os.name == "nt"to the powershel check statement, so has the same logic as the Linux tests, and sensibly skips windows tests when not on windows. Now everything passes :)Fixes #2970
Testing
uv run specify --helpuv sync && uv run pytestAI Disclosure
I did not use AI for any of the changes or debugging
But I did use it for a quick code review/ sanity check before submitting. Qwen 3 8B in ollama.
(And maybe Copilot will jump in here too with some more AI review 😉)