Fix HTML entities in sanitized titles - #3216
Merged
Merged
Conversation
Add an entity-aware plain-text sanitizer for titles, release names, headlines, and validation text while keeping encoded markup inert and Markdown body handling unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The sanitization changes span multiple user-facing surfaces and require final human review.
Review tier: Balanced
Findings: None
What changed in this PR
Adds entity-aware plain-text sanitization while preserving Markdown body behavior.
Changes:
- Introduces and tests
sanitize.PlainText. - Applies sanitization to titles, release names, headlines, and validation errors.
- Adds regression coverage for punctuation preservation and exact output.
| File | Description |
|---|---|
pkg/sanitize/sanitize.go |
Implements entity-aware plain-text sanitization. |
pkg/sanitize/sanitize_test.go |
Tests entities, malformed input, security, and idempotence. |
pkg/github/sanitize_coverage_test.go |
Verifies sanitization and serialized output. |
pkg/github/repositories.go |
Sanitizes blame commit headlines. |
pkg/github/minimal_types.go |
Updates title and release-name conversions. |
pkg/github/issues.go |
Updates issue and parent-title sanitization. |
pkg/github/discussions.go |
Updates discussion-title sanitization. |
pkg/errors/error.go |
Updates validation-text sanitization. |
pkg/errors/error_test.go |
Tests preserved validation-error punctuation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
github-mcp-server 1.12.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## Highlights - **New governance tools for agents.** Read and manage repository rulesets and custom properties across repository, organization, and enterprise levels. - **Faster, safer feature flags.** Functional availability rules evaluate lazily after static filtering, deduplicate checks per request, and preserve precise availability errors. - **Safer write operations.** Pin merge HEADs, recover file SHAs, use least-privilege public-repository access, and detect silently dropped labels. - **Richer review and discovery support.** Adds review range coordinates, thread resolution reasons, projected-header preflights, Server Card support, and Agent Plugins. - **Better content fidelity.** Markdown bodies, titles, release notes, comments, and commit messages preserve visible content while filtering unsafe invisible characters. ## What's Changed * Remove documentation for unavailable tool-search command by @tommaso-moro in github/github-mcp-server#3162 * Expose Copilot review thread resolution reasons by @cagesellchen in github/github-mcp-server#3123 * fix(repos): give create_or_update_file callers a SHA they can actually get by @dylanpulver in github/github-mcp-server#3131 * fix: allow public_repo for public contribution tools by @paulcakeface in github/github-mcp-server#3140 * Enable feature flags via URL query parameter (?features=) for headerless hosted connections by @CAOShurong in github/github-mcp-server#3146 * Add expectedHeadSha pinning to merge_pull_request by @jcosta1970 in github/github-mcp-server#3182 * Fix e2e harness compilation against go-github v89 and go-sdk v1.7 by @ppoffice in github/github-mcp-server#3187 * Return range coordinates for review comments by @yiheng-kkk in github/github-mcp-server#3193 * Fix issue_write silently dropped label errors by @SamMorrowDrums in github/github-mcp-server#3195 * fix(http): allow projected MCP headers in preflights by @SamMorrowDrums in github/github-mcp-server#3167 * Spell perPage the same way in every paginated tool by @karpovantonme in github/github-mcp-server#3142 * Add MCP Server Card (SEP-2127) types + handler by @SamMorrowDrums in github/github-mcp-server#2768 * Refactor feature flags to use functional availability rules by @SamMorrowDrums in github/github-mcp-server#3166 * feat(governance): add repository ruleset tools with multi-level scope challenge by @SamMorrowDrums in github/github-mcp-server#2991 * feat(governance): add custom properties tools by @SamMorrowDrums in github/github-mcp-server#2992 * Fix HTML entities in sanitized titles by @SamMorrowDrums in github/github-mcp-server#3216 * build(deps): bump fast-uri from 3.1.5 to 3.1.7 in /ui in the npm_and_yarn group across 1 directory by @dependabot[bot] in github/github-mcp-server#3208 * build(deps): bump the npm_and_yarn group across 1 directory with 2 updates by @dependabot[bot] in github/github-mcp-server#3217 * build(deps): bump github/codeql-action from 4.37.4 to 4.37.9 by @dependabot[bot] in github/github-mcp-server#3192 * feat: add Agent Plugins 1.0 package by @777genius in github/github-mcp-server#3169 * fix(sanitize): preserve Markdown body fidelity on read surfaces by @SamMorrowDrums in github/github-mcp-server#3177 * build(deps): bump actions/stale from 10 to 11 by @dependabot[bot] in github/github-mcp-server#3003 * Fix main CI sanitizer integration by @SamMorrowDrums in github/github-mcp-server#3219 ## New Contributors * @cagesellchen made their first contribution in github/github-mcp-server#3123 * @paulcakeface made their first contribution in github/github-mcp-server#3140 * @CAOShurong made their first contribution in github/github-mcp-server#3146 * @jcosta1970 made their first contribution in github/github-mcp-server#3182 * @ppoffice made their first contribution in github/github-mcp-server#3187 * @yiheng-kkk made their first contribution in github/github-mcp-server#3193 * @karpovantonme made their first contribution in github/github-mcp-server#3142 * @777genius made their first contribution in github/github-mcp-server#3169 **Full Changelog**: https://github.com/github/github-mcp-server/compare/v1.11.0...v1.12.0</pre> <p>View the full release notes at <a href="https://github.com/github/github-mcp-server/releases/tag/v1.12.0">https://github.com/github/github-mcp-server/releases/tag/v1.12.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!18304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
script/lintscript/testFixes #3214