Make digest image validation internals private - #7702
Conversation
There was a problem hiding this comment.
Pull request overview
Narrows image-resolver’s public API while preserving image-manifest validation.
Changes:
- Makes the digest pattern and validation helper module-private.
- Retains validation through
validateCustomImageManifest.
Show a summary per file
| File | Description |
|---|---|
src/image-resolver.ts |
Removes unnecessary exports from internal validation utilities. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
|
✅ Copilot review passed with no inline comments. @copilot Add the |
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓
|
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 Warning Firewall blocked 3 domainsThe following domains were blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "msfeed2.pkgs.visualstudio.com"
- "msfeed25.pkgs.visualstudio.com"
- "registry.npmjs.org"See Network Configuration for more information.
|
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤
|
|
✅ Smoke Claude passed
|
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...
|
|
✅ Contribution Check completed successfully! PR #7702 follows the contribution guidelines: the change is small and self-contained, fits
|
|
🔌 Smoke Services — All services reachable! ✅
|
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅
|
|
✅ Build Test Suite completed successfully!
|
|
❌ Smoke Gemini reports failed. Facets need polishing...
|
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤
|
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
|
🚀 Security Guard has started processing this pull request |
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓
|
|
Smoke Test: Copilot Engine —
Overall: PASS
|
|
Copilot Network Isolation Smoke Test — EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (github.com) reachable: Overall: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: Claude Engine Validation
Overall result: PASS
|
|
Smoke Test: Copilot BYOK (Direct) Mode — PASS ✅ GitHub MCP connectivity Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy sidecar.
|
Smoke Test: Services Connectivity
Overall: FAIL —
|
|
Smoke Test: Docker Sbx Validation
Overall: PASS cc
|
Warning Firewall blocked 3 domainsThe following domains were blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "msfeed2.pkgs.visualstudio.com"
- "msfeed25.pkgs.visualstudio.com"
- "registry.npmjs.org"See Network Configuration for more information.
|
📡 OTel Tracing Smoke Test Results
Summary: all 5 scenarios pass. No regressions detected.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS All 18 test projects across Bun, C++, Deno, .NET, Go, Java, Node.js, and Rust built/tested successfully through the AWF firewall (Java used a local Maven repo at
|
|
Make digest image validation internals private
|
Chroot Version Comparison
Result: Not all versions matched (Node.js mismatch) —
|
isDigestPinnedImageReferencewas exported fromimage-resolverdespite having no external consumers, unnecessarily widening the module API. The related digest-pinned image regex constant was similarly only used inside the defining file.Export surface
isDigestPinnedImageReferenceandDIGEST_PINNED_IMAGE_PATTERN.Behavior
validateCustomImageManifest.