Keep default image constants internal

[Copilot]

src/image-resolver.ts exposed default image constants that had no external consumers, making them look like supported public API. This narrows the module surface while preserving existing image resolution behavior.

• API surface cleanup

  • Removed public exports from internal default image constants:
    • DEFAULT_IMAGE_REGISTRY
    • DEFAULT_DIND_STAGING_IMAGE
    • DEFAULT_DOH_PROXY_IMAGE

• Regression coverage

  • Added a focused assertion that these defaults are not exported from image-resolver.

const DEFAULT_IMAGE_REGISTRY = 'ghcr.io/github/gh-aw-firewall';
const DEFAULT_DIND_STAGING_IMAGE = 'ghcr.io/github/gh-aw-firewall/agent:latest';
const DEFAULT_DOH_PROXY_IMAGE = 'cloudflare/cloudflared:latest';

• Fixes [Export Audit] DEFAULT_IMAGE_* constants - unused image configuration exports #7690

[Copilot]

Pull request overview

Narrows image-resolver’s public API while preserving image-resolution behavior.

Changes:

• Makes three default image constants module-private.
• Adds regression coverage confirming they are not exported.

Show a summary per file

File	Description
src/image-resolver.ts	Removes exports from internal defaults.
src/image-resolver.test.ts	Verifies the defaults remain private.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

[github-actions]

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	93.85%	93.87%	📈 +0.02%
Statements	92.73%	92.74%	➡️ +0.01%
Functions	93.16%	93.16%	➡️ +0.00%
Branches	86.11%	86.12%	📈 +0.01%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
src/log-directory-setup.ts	96.2% → 100.0% (+3.78%)	96.3% → 100.0% (+3.71%)

---

Coverage comparison generated by scripts/ci/compare-coverage.ts

[github-actions]

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

[github-actions]

✅ Build Test Suite completed successfully!

Generated by Build Test Suite for #7701

[github-actions]

🚀 Security Guard has started processing this pull request

[github-actions]

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

📡 OTel tracing validated by Smoke OTel Tracing

[github-actions]

📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Docker Sbx

[github-actions]

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

Warning

Firewall blocked 3 domains

The following domains were blocked by the firewall during workflow execution:

• msfeed2.pkgs.visualstudio.com
• msfeed25.pkgs.visualstudio.com
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "msfeed2.pkgs.visualstudio.com"
    - "msfeed25.pkgs.visualstudio.com"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex

[github-actions]

✅ Smoke Claude passed

Generated by Smoke Claude for #7701

[github-actions]

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

[github-actions]

❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed...

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

[github-actions]

✅ Contribution Check completed successfully!

Contribution check complete: the PR updates internals only, includes a focused regression test, and its description clearly references the related issue (#7690). No guideline violations found that warrant a review comment.

Generated by Contribution Check for #7701

[github-actions]

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation

[github-actions]

❌ Smoke Gemini reports failed. Facets need polishing...

💎 Faceted by Smoke Gemini

[github-actions]

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

🔑 BYOK report filed by Smoke Copilot BYOK

[github-actions]

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

[github-actions]

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

[github-actions]

Smoke Test: Claude Engine Validation

Check	Result
API status	✅ PASS
gh check	✅ PASS
File status	✅ PASS

Overall result: PASS

Generated by Smoke Claude for #7701 · haiku45 · 32.5 AIC · ⊞ 4.5K · ◷
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: Copilot Engine

• ✅ GitHub MCP connectivity (e.g. PR Upgrade gh-aw workflows to latest pre-release #7695: Upgrade gh-aw workflows to latest pre-release, PR fix: preserve agent startup with restricted tmp #7679: fix: preserve agent startup with restricted tmp)
• ✅ GitHub.com connectivity (HTTP 200)
• ✅ File write/read test

Overall: PASS

cc @lpcox

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

[github-actions]

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (github.com) reachable: allowed=200
✅ Non-allowlisted domain (example.com) blocked: CONNECT tunnel failed (403)

Overall: PASS

@lpcox

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• example.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "example.com"

See Network Configuration for more information.

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: Copilot BYOK (Direct Mode) ✅

Tests:

• ✅ GitHub MCP connectivity (PRs Upgrade gh-aw workflows to latest pre-release #7695, fix: preserve agent startup with restricted tmp #7679 verified)
• ✅ GitHub.com connectivity (HTTP 200)
• ✅ File write/read (smoke-test-copilot-byok.txt exists)
• ✅ BYOK inference path (direct mode via api-proxy → api.githubcopilot.com)

Status: PASS — Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY)

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

[github-actions]

Docker Sbx Smoke Test — @lpcox

• ✅ GitHub MCP connectivity (PR Upgrade gh-aw workflows to latest pre-release #7695, fix: preserve agent startup with restricted tmp #7679)
• ✅ github.com HTTP 200
• ✅ File write/read test passed

Overall: PASS

📰 BREAKING: Report filed by Smoke Docker Sbx
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: Services Connectivity

• Redis PING: ❌ (Temporary failure in name resolution)
• PostgreSQL pg_isready: ❌ (no response)
• PostgreSQL SELECT 1: ❌ (could not translate host name)

Overall: FAIL — host.docker.internal could not be resolved from the sandbox.

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

[github-actions]

Smoke test: FAIL

• Merged PR review: ❌ safeinputs-gh unavailable
• PR query (pr list --limit 2): ❌ safeinputs-gh unavailable
• Playwright github.com title contains GitHub: ✅
• Temp file write/read: ✅
• Discussion query/comment: ❌ read tool unavailable; discussion comments disabled here
• AWF build (npm ci, npm run build): ✅
  Overall: FAIL

Warning

Firewall blocked 3 domains

The following domains were blocked by the firewall during workflow execution:

• msfeed2.pkgs.visualstudio.com
• msfeed25.pkgs.visualstudio.com
• registry.npmjs.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "msfeed2.pkgs.visualstudio.com"
    - "msfeed25.pkgs.visualstudio.com"
    - "registry.npmjs.org"

See Network Configuration for more information.

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

[github-actions]

Smoke test results:

• GitHub MCP connectivity: ✅
• GitHub.com connectivity: ✅
• File write/read: ✅
• BYOK inference: ✅

Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra

Overall: PASS

cc @Copilot @lpcox

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
_{Add label ready-for-aw to run again}

[github-actions]

Smoke Test: API Proxy OTel Tracing — Results

• ✅ Scenario 1 (Module Loading): otel.js loads successfully, exporting startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled, plus internal exporter/parsing helpers.
• ✅ Scenario 2 (Test Suite): otel.test.js, otel-fanout.test.js, otel-workload-identity.test.js — 3 suites, 68/68 tests passed.
• ✅ Scenario 3 (Env Var Forwarding): env-passthrough.ts forwards GITHUB_AW_OTEL_TRACE_ID/GITHUB_AW_OTEL_PARENT_SPAN_ID/COPILOT_OTEL_FILE_EXPORTER_PATH into the agent container; api-proxy-env-config.ts (buildOtelEnv) forwards OTLP endpoint/headers, service name, and parent trace context into the api-proxy container.
• ✅ Scenario 4 (Token Tracker Integration): onUsage callback confirmed in token-tracker-http.js as the OTEL hook point, invoked after normalized usage extraction.
• ⚠️ Scenario 5 (OTEL Diagnostics): No live LLM traffic ran in this workflow session, so no spans were exported/collected — expected graceful-degradation behavior, not a failure.

Overall: PASS — all core OTEL integration points verified functional; no unexpected failures.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

[github-actions]

Chroot Version Comparison

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.14	Python 3.12.14	✅ YES
Node.js	v24.19.0	v22.23.2	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Result: Not all tests passed — Node.js version differs between host and chroot environment. smoke-chroot label not applied.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

[github-actions]

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A (ran, printed "Hello, World!")	✅ PASS
.NET	json-parse	✅	N/A (ran, correct JSON output)	✅ PASS
Go	color	✅	passed	✅ PASS
Go	env	✅	passed	✅ PASS
Go	uuid	✅	passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — PASS

Notes:

• All repository clones succeeded (no CLONE_FAILED).
• Java tests initially hit Could not create local repository at /home/runner/.m2/repository (permission denied on a pre-existing root-owned ~/.m2/.m2 path). Worked around locally with -Dmaven.repo.local=/tmp/gh-aw/agent/m2repo; Maven proxy config (~/.m2/settings.xml pointing to squid-proxy:3128) worked as expected — no other issues found.
• No firewall/network egress errors observed across any ecosystem.

Generated by Build Test Suite for #7701 · auto · 33.5 AIC · ⊞ 12K · ◷
_{Add label ready-for-aw to run again}