Hide Cloud Hypervisor runtime backend implementation - #7700
Conversation
There was a problem hiding this comment.
Pull request overview
Hides the Cloud Hypervisor backend implementation behind its public interface, resolving #7691.
Changes:
- Makes the implementation class file-private.
- Adds an internal dependency-injection test helper.
- Updates tests to use public or test-specific factory seams.
Show a summary per file
| File | Description |
|---|---|
src/cloud-hypervisor-runtime-backend.ts |
Narrows the exported API and adds a test construction helper. |
src/cloud-hypervisor-runtime-backend.test.ts |
Replaces direct class construction with factory helpers. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
|
✅ Copilot review passed with no inline comments. @copilot Add the |
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤
|
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 Warning Firewall blocked 3 domainsThe following domains were blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "msfeed2.pkgs.visualstudio.com"
- "msfeed25.pkgs.visualstudio.com"
- "registry.npmjs.org"See Network Configuration for more information.
|
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓
|
|
🚀 Security Guard has started processing this pull request |
|
✅ Smoke Claude passed
|
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅
|
|
✅ Build Test Suite completed successfully!
|
|
❌ Smoke Gemini reports failed. Facets need polishing...
|
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓
|
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
🔌 Smoke Services — All services reachable! ✅
|
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.
|
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤
|
|
❌ Contribution Check failed. Please review the logs for details.
|
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓
|
|
Smoke Test: Copilot Engine ✅ GitHub MCP connectivity (PR #7695: Upgrade gh-aw workflows to latest pre-release) Overall: PASS cc
|
Smoke Test: Claude Engine Validation
Overall result: PASS
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (github.com) reachable: Overall: PASS
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
|
Docker Sbx Smoke Test —
Overall: PASS
|
|
GitHub MCP PRs: Make digest image validation internals private; Keep default image constants internal: ✅
|
Chroot Version Comparison Results
Overall: FAILED — Node.js version mismatch between host and chroot environment. The
|
|
Smoke Test: Copilot BYOK (Direct) Mode ✅ PASS
Running in direct BYOK mode via
|
|
Smoke Test Results: GitHub Actions Services Connectivity
Overall: FAIL —
|
|
Upgrade gh-aw workflows to latest pre-release GitHub MCP: ❌ Warning Firewall blocked 3 domainsThe following domains were blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "msfeed2.pkgs.visualstudio.com"
- "msfeed25.pkgs.visualstudio.com"
- "registry.npmjs.org"See Network Configuration for more information.
|
|
GitHub MCP Testing: ❌ Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra Overall: FAIL
|
Smoke Test: API Proxy OpenTelemetry Tracing
Overall: PASS — all verifiable scenarios (1–4) succeeded; scenario 5 pending live run data.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS Note: Java's default All other ecosystems (Bun, C++, Deno, .NET, Go, Node.js, Rust) built/tested cleanly with no proxy or network issues.
|
The Cloud Hypervisor runtime backend class was exported despite having no external production consumers, expanding the API surface of a security-critical microVM boundary.
API surface
CloudHypervisorRuntimeBackendfile-private.createCloudHypervisorRuntimeBackend()as the public construction path.ExternalAgentRuntimeBackendinterface from the factory.Tests