Skip to content

C++: Refine comment by removing outdate workaround reference#19974

Closed
IdrissRio wants to merge 1 commit intomainfrom
idrissrio/workaround-comment
Closed

C++: Refine comment by removing outdate workaround reference#19974
IdrissRio wants to merge 1 commit intomainfrom
idrissrio/workaround-comment

Conversation

@IdrissRio
Copy link
Copy Markdown
Contributor

See linked issue.

@github-actions github-actions Bot added the C++ label Jul 4, 2025
@IdrissRio IdrissRio added the no-change-note-required This PR does not need a change note label Jul 4, 2025
@IdrissRio IdrissRio changed the title C++: Refine comment removing outdate workaround reference C++: Refine comment by removing outdate workaround reference Jul 4, 2025
@IdrissRio IdrissRio marked this pull request as ready for review July 4, 2025 10:15
Copilot AI review requested due to automatic review settings July 4, 2025 10:15
@IdrissRio IdrissRio requested a review from a team as a code owner July 4, 2025 10:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jketema
Copy link
Copy Markdown
Contributor

jketema commented Jul 4, 2025

I think we should leave this as-is and not merge this. As it's technically a workaround (see also my comment on the internal issue).

@IdrissRio
Copy link
Copy Markdown
Contributor Author

I missed your comment in the issue. Thanks. I'll close the PR without merging it.

@IdrissRio IdrissRio closed this Jul 5, 2025
@IdrissRio IdrissRio deleted the idrissrio/workaround-comment branch July 5, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C++ no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants