C++: Refactor Iterator SSA flow to use the data flow integration module.#19155
Merged
aschackmull merged 3 commits intogithub:mainfrom Apr 1, 2025
Merged
C++: Refactor Iterator SSA flow to use the data flow integration module.#19155aschackmull merged 3 commits intogithub:mainfrom
aschackmull merged 3 commits intogithub:mainfrom
Conversation
aschackmull
added
the
no-change-note-required
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll: Language not supported
- cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternals.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
MathiasVP
reviewed
Mar 31, 2025
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
Thanks for getting this over the finish line, Schack! The changes LGTM! I'll it to someone from the C team to approve it if DCA is happy
jketema
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit-by-commit review encouraged as I was able to make a few initial simplifications that should make the actual switch simpler to review.