Skip to content

Every page ships all four stylesheets whether it needs them or not #58

Description

@pushpam2404

Context

All seven pages load theme.css, base.css, layout.css and components.css. components.css is 450 lines covering the wall, the glossary, the FAQ, callouts, steps and copy buttons — and the 404 page uses almost none of it. Four blocking requests before anything paints, on a connection that at the event will be shared by eighty phones.

What to change

Files: All seven .html files, the css/ directory, and a new build step

Requirements:

  • Measure first. State the current numbers in the pull request — requests, total CSS, and what actually gets used per page
  • Then propose an approach: inlining critical CSS, splitting per page, or concatenating into one file
  • No CSS framework and no preprocessor — the no-build-step property is deliberate and worth keeping if you can
  • If you add a build step, it must run in CI and never require a contributor to run it locally
  • Both themes must be identical afterwards, and the flash-of-wrong-theme fix must not regress

Acceptance criteria

  • Before and after numbers are in the pull request
  • Every page looks identical in both themes
  • No theme flash
  • Contributors can still edit CSS without running a build
  • Measurably fewer bytes or requests, stated

How to verify locally

Dev tools → Network → disable cache → hard reload. Record requests and transferred size.

python3 -m http.server 8000

Then open http://localhost:8000.

Difficulty

Advanced. Measure before you change anything — a pull request here without numbers cannot be reviewed.


New here? Comment /claim on this issue and a bot will assign it to you. Then read CONTRIBUTING.md.

Stuck at any point? Comment here saying what you have tried and where it stopped working — that is not an admission of failure, it is how we find out the instructions were unclear. You can also come to a PR Debug Clinic (Oct 12 or Oct 21).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions