Add SPDX identifier rewriting - #23
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new public API to rewrite identifiers within a parsed SPDX expression (licenses, exceptions, and license references) while preserving expression structure/precedence, along with documentation, tests, and a benchmark.
Changes:
- Introduces
RewriteIdentifiersand an internal AST-rewrite helper to apply an identifier mapping without re-parsing. - Adds focused unit tests for rewrite ordering/immutability and special values, plus a benchmark.
- Documents the new API in the README with an example.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rewrite.go | Adds the identifier-rewriting API and recursive AST traversal. |
| rewrite_test.go | Adds unit tests and a benchmark for the new rewriting behavior. |
| README.md | Documents how to use RewriteIdentifiers with an example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
RewriteIdentifiersfor replacing license IDs, exception IDs, and license references in a parsed SPDX expression while preserving operator precedence. Documents the API and adds focused coverage plus a benchmark.