Return declared licenses from ParseResult - #50
Open
abhinavgautam01 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
Summary
Add declared license metadata to
ParseResult, allowing consumers to access license information directly from supported package manifests.This introduces:
Licenses []stringfor raw declared license valuesLicenseFile stringfor a manifest-relative license filesetup.cfgand OPAM manifest supportLicense values are returned without SPDX normalization, keeping this package independent of
github.com/git-pkgs/spdx.Supported formats
License metadata is extracted from:
package.jsonandbower.jsonCargo.tomlpyproject.toml,setup.py, andsetup.cfg*.gemspec*.podspeccomposer.jsonpom.xml*.nuspec*.cabalDESCRIPTIONmix.exsopamand*.opamelm.jsonandelm-package.jsonFormats without declared license fields, such as
go.modandpubspec.yaml, continue to return empty values.For formats that allow multiple license files,
LicenseFilecontains the first declared path, matching the singular public API proposed in the issue.Validation
gofmtgit diff --checkgo build ./...go vet ./...go test ./...go test -race ./...golangci-lint— 0 issuesFollow-up hardening
A second review added coverage and fixes for:
elm.jsondependenciessetup.cfglicense values and version constraintspackage/0declarations