Fix direct registry latest version selection - #53
Merged
andrew merged 2 commits intoJul 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the direct-registry fallback logic used by RegistriesClient.BulkLookup when a registry response omits LatestVersion, ensuring “latest” selection respects both release availability and ecosystem-specific version ordering.
Changes:
- Filters out unavailable versions (
yanked,deprecated,retracted) when computing the fallback latest version. - Switches version comparison to
vers.CompareWithSchemeusing the PURL type (ecosystem scheme). - Expands unit tests to cover unavailable-status filtering and scheme-specific ordering (including Debian-style versions).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| registries.go | Computes fallback latest version using scheme-aware comparison and filters unavailable versions. |
| enrichment_test.go | Adds table-driven tests for unavailable statuses and scheme-specific ordering behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #52.
This updates the direct registry fallback path for packages where
LatestVersionis not populated by the registry response.Changes
yankeddeprecatedretractedvers.CompareWithSchemewith the PURL type instead of genericvers.CompareTesting