Update outline to v0.1.8 - #124
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the brief outline command to use github.com/git-pkgs/outline v0.1.8 (which now inherits content-based binary classification via magic) and adds command-level tests/benchmarks to lock in the new behavior.
Changes:
- Bump
github.com/git-pkgs/outlineto v0.1.8 (and pull ingithub.com/git-pkgs/magicindirectly). - Refactor
runOutlineto accept anio.Writerto make output testable. - Add a regression test for ASCII PDF content being detected/skipped as binary and add an outline packing benchmark.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Bumps outline to v0.1.8 and adds magic as an indirect dependency. |
| go.sum | Updates dependency checksums for outline v0.1.8 and magic v0.1.0. |
| cmd/brief/outline.go | Routes outline output through an injected io.Writer instead of hard-coding os.Stdout. |
| cmd/brief/outline_test.go | Adds regression test for binary skipping and a benchmark for outline.Pack. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
outlineto v0.1.8 sobrief outlineinherits content-based binary classification frommagic.Add a command-level fixture for ASCII PDF content that the previous classifier treated as text and a fixed outline benchmark. Interleaved measurements on this repository show startup at +1.05%, a normal scan at +0.16%, and outline at -0.47%. The linked binary grows by 33,776 bytes, while benchmark allocations fall from 1,929 to 1,919.