Skip to content

Update outline to v0.1.8 - #124

Merged
andrew merged 2 commits into
mainfrom
magic-integration
Jul 31, 2026
Merged

Update outline to v0.1.8#124
andrew merged 2 commits into
mainfrom
magic-integration

Conversation

@andrew

@andrew andrew commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Update outline to v0.1.8 so brief outline inherits content-based binary classification from magic.

Add a command-level fixture for ASCII PDF content that the previous classifier treated as text and a fixed outline benchmark. Interleaved measurements on this repository show startup at +1.05%, a normal scan at +0.16%, and outline at -0.47%. The linked binary grows by 33,776 bytes, while benchmark allocations fall from 1,929 to 1,919.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the brief outline command to use github.com/git-pkgs/outline v0.1.8 (which now inherits content-based binary classification via magic) and adds command-level tests/benchmarks to lock in the new behavior.

Changes:

  • Bump github.com/git-pkgs/outline to v0.1.8 (and pull in github.com/git-pkgs/magic indirectly).
  • Refactor runOutline to accept an io.Writer to make output testable.
  • Add a regression test for ASCII PDF content being detected/skipped as binary and add an outline packing benchmark.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
go.mod Bumps outline to v0.1.8 and adds magic as an indirect dependency.
go.sum Updates dependency checksums for outline v0.1.8 and magic v0.1.0.
cmd/brief/outline.go Routes outline output through an injected io.Writer instead of hard-coding os.Stdout.
cmd/brief/outline_test.go Adds regression test for binary skipping and a benchmark for outline.Pack.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmd/brief/outline_test.go
Comment thread cmd/brief/outline_test.go Outdated
@andrew
andrew merged commit 2695f79 into main Jul 31, 2026
8 checks passed
@andrew
andrew deleted the magic-integration branch July 31, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants