detect: recognise DISCLOSURE as a security resource - #119
Merged
Conversation
npm's dual-use content policy requires a DISCLOSURE file at the package root describing security-relevant capabilities. Report it under resources.security.disclosure alongside SECURITY and THREAT_MODEL. https://docs.npmjs.com/policies/dual-use
There was a problem hiding this comment.
Pull request overview
This PR extends Brief’s resource detection knowledge base to recognize an npm dual-use DISCLOSURE file (at the package root) as a security-related resource, and verifies the resulting resources.security.disclosure output in detection tests.
Changes:
- Add a new security resource definition for
Disclosurewithfield = "disclosure"and root-level filename patterns. - Extend
TestResourceGroupsto ensure a rootDISCLOSUREfile is detected and reported underresources.security.disclosure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| knowledge/_shared/_resources.toml | Adds a new security resource definition for disclosure with filename patterns. |
| detect/detect_test.go | Adds coverage asserting DISCLOSURE is reported as resources.security.disclosure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm's dual-use content policy requires a
DISCLOSUREfile at the package root describing security-relevant capabilities, sitting alongsideLICENSE. Report it underresources.security.disclosurealongsidepolicy,threat_modelandaudit.Announcement: https://github.blog/changelog/2026-07-28-npm-publish-time-malware-scanning-and-dual-use-metadata/
Policy: https://docs.npmjs.com/policies/dual-use