Repository navigation
Skip global PAX metadata in TAR readers - #71
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the changes that prevent global PAX metadata from being treated as TAR files.
No open issues 🎉
What changed in this PR
This PR prevents global PAX metadata from appearing as files in TAR archives, restoring common-root detection, normalized paths, and extraction behavior.
Changes:
- Skip global PAX headers in buffered and streaming TAR readers.
- Add regression coverage for compressed TAR, gem, and conda archives, including stream entry limits and real files named
pax_global_header. - Verify browser root detection and filesystem extraction.
| File | Description |
|---|---|
tar.go |
Skip global PAX headers before counting or collecting archive entries. |
tar_pax_test.go |
Test metadata filtering, real-file preservation, entry limits, and root detection. |
stream_tar.go |
Skip global PAX headers when advancing the stream. |
extract_test.go |
Verify extraction omits metadata while preserving real files. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Git-generated tarballs include a global PAX header named
pax_global_header. Both readers expose it as an empty regular file with mode000. This prevents common-root detection, breaks normalized file paths and archive comparisons, and causes permission errors when consumers scan extracted files.Skip
tar.TypeXGlobalHeaderin buffered and streaming TAR readers. Regression coverage checks root detection, extraction, stream entry limits, and preservation of real files namedpax_global_headeracross compressed TAR, gem, and conda archives.