Skip to content

chore(deps): update dependency jsdom to v30 - #2679

Closed
renovate-bot wants to merge 1 commit into
ghiscoding:masterfrom
renovate-bot:renovate/jsdom-30.x
Closed

chore(deps): update dependency jsdom to v30#2679
renovate-bot wants to merge 1 commit into
ghiscoding:masterfrom
renovate-bot:renovate/jsdom-30.x

Conversation

@renovate-bot

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
jsdom ^29.1.1^30.0.0 age confidence

Release Notes

jsdom/jsdom (jsdom)

v30.0.0

Compare Source


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "every 4 weeks on friday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@forking-renovate forking-renovate Bot added 📦 dependencies Pull requests that update a dependency file 🤖 bot labels Jul 29, 2026
@renovate-bot renovate-bot added 📦 dependencies Pull requests that update a dependency file 🤖 bot labels Jul 29, 2026
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (66d8876) to head (ecac059).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #2679     +/-   ##
=========================================
- Coverage   100.0%   100.0%   -0.0%     
=========================================
  Files         200      200             
  Lines       25469    25469             
  Branches     9007     9007             
=========================================
- Hits        25469    25467      -2     
- Misses          0        2      +2     
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <ø> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2679

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2679

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2679

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2679

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2679

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2679

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2679

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2679

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2679

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2679

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2679

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2679

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2679

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2679

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2679

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2679

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2679

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2679

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2679

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2679

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2679

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2679

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2679

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2679

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2679

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2679

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2679

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2679

commit: ecac059

@ghiscoding

Copy link
Copy Markdown
Owner

jsdom v30 seems to cause test regressions, potentially because of changes in getComputedStyle (which they already patch a regression in v30.0.1 but that isn't enough for my tests to pass).

in conclusion when trying to debug this with copilot, it wrote:

Yes, your diagnosis is likely correct: this looks like a jsdom v30 behavior regression/change, not a SlickGrid source regression.

What I validated:

  1. The failing path is exactly the computed-style accumulation in slickGrid.ts.
  2. I tested a test-only avenue (no SlickGrid source changes): forcing getComputedStyle mocking to cover both window and global.
  3. That reduced failures from 13 to 8, but introduced other layout/dimension expectation mismatches in slickGrid.spec.ts, which indicates broader jsdom v30 CSS/computed-style behavior drift.
  4. I reverted that exploratory patch; no lingering edits from this attempt in test setup.

Conclusion:

  1. Postponing jsdom v30 upgrade is a reasonable and defensible call right now.
  2. If you still want to pursue upgrade later, the safest path is a dedicated test-harness hardening effort (centralized computed-style shim for jsdom v30) rather than touching slickGrid.ts.

so let's close this for now and maybe revisit later after more jsdom users test their new version and possibly (hopefully) more regression patches are pushed

@ghiscoding ghiscoding closed this Jul 29, 2026
@forking-renovate

Copy link
Copy Markdown

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 30.x releases. But if you manually upgrade to 30.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot
renovate-bot deleted the renovate/jsdom-30.x branch July 29, 2026 19:33
ghiscoding added a commit that referenced this pull request Jul 29, 2026
- new major version seems to cause slickgrid.ts test failures because of `getComputedStyle()` changes, see #2679 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 bot 📦 dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants