Skip to content

fix: align frozen-band cell-cleanup ranges with the (inclusive) render ranges - #2674

Merged
ghiscoding merged 1 commit into
masterfrom
bugfix/frozen-range-off-by-one
Aug 3, 2026
Merged

fix: align frozen-band cell-cleanup ranges with the (inclusive) render ranges#2674
ghiscoding merged 1 commit into
masterfrom
bugfix/frozen-range-off-by-one

Conversation

@ghiscoding

@ghiscoding ghiscoding commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Port bug fix from 6pac/SlickGrid PR 6pac/SlickGrid#1259 into slickgrid-universal

The bug

render()'s frozen-band cleanUpAndRenderCells ranges used bottom = getDataLength() (frozenBottom) / frozenRow (top mode), while the frozen renderRows ranges directly below use getDataLength() - 1 / frozenRow - 1. Both are consumed as inclusive row ranges, so the cleanup pass overshot by one row: in top mode the first scrollable row (index frozenRow) was processed by both the frozen pass and the main pass of the same render() call. (In bottom mode the overshoot index equals getDataLength(), which is never cached, so it was skipped.)

The fix

Two-token change aligning the cleanup bounds with the render bounds, so the invariant cleanup range == render range actually holds.

Why no new test

There is no user-observable effect to pin: the double-processed boundary row's cleanup and render are idempotent within a single render() call, so pre-fix and post-fix DOM are identical — this removes redundant work and a latent correctness hazard, not a visible symptom. A 'repro' test would pass on both sides and be worthless. Non-regression is covered by the existing frozen-row suites (ran frozen-rows / frozen-columns-and-rows / frozen spreadsheet locally, 22/22 green).

Part of the quirks-triage series:
6pac/SlickGrid#1255
6pac/SlickGrid#1256
6pac/SlickGrid#1257
6pac/SlickGrid#1258

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (15d9833) to head (7c38a03).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2674   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         200      200           
  Lines       25452    25452           
  Branches     8999     8999           
=======================================
  Hits        25452    25452           
Flag Coverage Δ
angular 100.0% <ø> (ø)
universal 100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown
angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2674

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2674

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2674

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2674

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2674

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2674

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2674

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2674

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2674

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2674

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2674

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2674

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2674

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2674

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2674

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2674

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2674

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2674

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2674

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2674

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2674

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2674

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2674

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2674

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2674

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2674

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2674

@slickgrid-universal/web-mcp

npm i https://pkg.pr.new/@slickgrid-universal/web-mcp@2674

commit: 7c38a03

@ghiscoding ghiscoding added the AI label Jul 29, 2026
@ghiscoding
ghiscoding merged commit 4fa25f8 into master Aug 3, 2026
15 checks passed
@ghiscoding
ghiscoding deleted the bugfix/frozen-range-off-by-one branch August 3, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant