Skip to content

metal: fix tuning include path in subprojects - #28644

Draft
obrr-hhx wants to merge 1 commit into
ggml-org:masterfrom
obrr-hhx:fix/metal-tuning-subproject-include
Draft

metal: fix tuning include path in subprojects#28644
obrr-hhx wants to merge 1 commit into
ggml-org:masterfrom
obrr-hhx:fix/metal-tuning-subproject-include

Conversation

@obrr-hhx

@obrr-hhx obrr-hhx commented Sep 9, 2026

Copy link
Copy Markdown

Overview

Fixes #28114.

Resolve the Metal tuning include directory relative to its own CMakeLists.txt. When llama.cpp is included through FetchContent, CMAKE_SOURCE_DIR points to the consuming project and ggml-metal-tuning fails to find ggml-metal-tuning.h.

Validation

  • Reproduced the missing-header build failure with a minimal FetchContent consumer before the change.
  • Built and linked ggml-metal-tuning successfully in the same consumer after the change.
  • Built and linked ggml-metal-tuning in a standalone Metal build.
  • Passed applicable pre-commit-hooks v4.6.0 checks (trailing whitespace, final newline, file size) and git diff --check.

Requirements

The change is limited to the include path in tools/tuning/CMakeLists.txt. No runtime code changes.

@ggml-gh-bot

ggml-gh-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Hi @obrr-hhx, thanks for your contribution!

Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:

  • PR Template not respected: Please respect the template when creating a new pull request. Make sure to fill out all required sections.

Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below.

@ggml-gh-bot ggml-gh-bot Bot added the draft PR will be changed to draft by github-actions bot label Sep 9, 2026
@github-actions
github-actions Bot marked this pull request as draft September 9, 2026 10:49
@github-actions github-actions Bot added examples and removed draft PR will be changed to draft by github-actions bot labels Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile bug: tools/tuning hardcodes ${CMAKE_SOURCE_DIR}, breaks FetchContent consumers (ggml-metal-tuning.h not found)

1 participant