metal: fix tuning include path in subprojects - #28644
Draft
obrr-hhx wants to merge 1 commit into
Draft
Conversation
|
Hi @obrr-hhx, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #28114.
Resolve the Metal tuning include directory relative to its own CMakeLists.txt. When llama.cpp is included through FetchContent, CMAKE_SOURCE_DIR points to the consuming project and ggml-metal-tuning fails to find ggml-metal-tuning.h.
Validation
Requirements
The change is limited to the include path in tools/tuning/CMakeLists.txt. No runtime code changes.