model: fix all granite family parameter counts - #28643
Open
taronaeo wants to merge 3 commits into
Open
Conversation
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
taronaeo
commented
Sep 9, 2026
CISC
approved these changes
Sep 9, 2026
gabe-l-hart
suggested changes
Sep 9, 2026
gabe-l-hart
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for cleaning all this up! This has been on my TODO list for a while, but never come to the top. Your question about GraniteMoe w/ 40 layers surfaced that the source of that line was an accidental copy over during refactors, so it would be great to strip it out now while this cleanup is going on.
Signed-off-by: Aaron Teo <aaron.teo1@ibm.com>
Member
Author
|
Latest push addressed review comments + removed the unused Granite MoE 40 layers check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
cont: #28632
After #28632, I realised that quite a lot of our Granite family parameter counts are either inaccurate (2B model reported as 3B), missing, or using dense model naming schemes when the model is MoE or hybrid.
This PR fixes all Granite family parameter counts reported in
llama-bench.Additional information
cc: @gabe-l-hart
Requirements