HIP: tune MMVQ batch thresholds on RDNA3.5 - #28613
Open
SimonTeixidor wants to merge 1 commit into
Open
Conversation
Add per-type MMVQ batch-size tuning for RDNA3.5 in ggml_cuda_should_use_mmvq, which speeds up batched generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
ggml_cuda_should_use_mmvqhad no per-type tuning for RDNA3.5 and fell throughto a flat
ne11 <= MMVQ_MAX_BATCH_SIZE(8). This PR adds a table for it whichgives a performance boost for batched generation.
Additional information
I introduced a temporary env var override which allowed me to sweep ne11 1-16 with
test-backend-ops perf -o MUL_MAT.Results
ne11 <= 2ne11 <= 3ne11 <= 4ne11 <= 5ne11 <= 6End-to-end (Strix Halo / gfx1151, Qwen3.8-27B-UD-IQ4_XS,
llama-batched-bench, S_TG)test-backend-ops -o MUL_MAT: 1288/1288.Requirements