Skip to content

feat: add FAQ item to desktop navbar#330

Merged
Nitin-kumar-yadav1307 merged 1 commit into
geturbackend:mainfrom
deepsikha-dash:fix-326-add-faq-navbar
Jun 21, 2026
Merged

feat: add FAQ item to desktop navbar#330
Nitin-kumar-yadav1307 merged 1 commit into
geturbackend:mainfrom
deepsikha-dash:fix-326-add-faq-navbar

Conversation

@deepsikha-dash

@deepsikha-dash deepsikha-dash commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

🚀 Pull Request Description

Fixes #326

🛠️ Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement (Frontend only)
  • ⚙️ Refactor / Chore

🧪 Testing & Validation

Backend Verification:

  • I have run npm test in the backend/ directory and all tests passed.
  • I have verified the API endpoints using Postman/Thunder Client.
  • New unit tests have been added (if applicable).

Frontend Verification:

  • I have run npm run lint in the frontend/ directory.
  • Verified the UI changes on different screen sizes (Responsive).
  • Checked for any console errors in the browser dev tools.

📸 Screenshots / Recordings (Optional)

Added a dedicated FAQ item to the desktop navigation bar. Clicking the item smoothly navigates users to the existing Common Questions section. The current design and responsiveness are preserved.
Screenshot 2026-06-20 214600
Screenshot 2026-06-20 214614

✅ Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings or errors.
  • I have updated the documentation (README/Docs) accordingly.

Built with ❤️ for urBackend.

Summary by CodeRabbit

  • New Features

    • Added an FAQ navigation link to the main navigation/menu.
  • Bug Fixes

    • Fixed the mobile menu showing the FAQ link twice by consolidating the FAQ entry into the shared navigation items.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1bff234a-0394-4f43-b96a-f425301f6127

📥 Commits

Reviewing files that changed from the base of the PR and between 720dcca and 146b29c.

📒 Files selected for processing (1)
  • apps/web-dashboard/src/pages/LandingPage/index.jsx

📝 Walkthrough

Walkthrough

A FAQ entry (href: '/#faq') is added to the NAV_ITEMS array, and the hardcoded FAQ item previously present in MOBILE_MENU_ITEMS is removed. Both desktop and mobile navigation now derive the FAQ link from a single source, eliminating duplication.

FAQ Navigation Consolidation

Layer / File(s) Summary
FAQ entry added to NAV_ITEMS, hardcoded FAQ removed from MOBILE_MENU_ITEMS
apps/web-dashboard/src/pages/LandingPage/index.jsx
Inserts { label: 'FAQ', href: '/#faq' } into NAV_ITEMS and removes the duplicate hardcoded FAQ item from MOBILE_MENU_ITEMS. The mobile menu now derives the FAQ link solely from the spread of NAV_ITEMS, avoiding duplication.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny hopped in with a question to share,
"Add FAQ to nav, show it everywhere!"
One line in, one duplicate out,
Navigation consolidation—no more doubt! 🐇
Clean and simple, the nav's unified at last,
No more looking back, the duplication's past!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The PR partially addresses issue #326 by adding FAQ to desktop navigation, but fails to properly implement it for mobile navigation (duplicate rendering issue identified in reviews). Remove the hardcoded FAQ item from MOBILE_MENU_ITEMS to eliminate the duplicate entry and ensure the mobile menu correctly derives FAQ solely from NAV_ITEMS as intended.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main change: adding an FAQ item to the desktop navbar, which is the primary objective of this pull request.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue #326 objective of adding FAQ navigation items to the navbar; no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
apps/web-dashboard/src/pages/LandingPage/index.jsx (1)

604-612: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove duplicated FAQ entry in mobile menu (root cause in menu composition).

Line 604 adds FAQ to NAV_ITEMS, and Line 611 adds FAQ again in MOBILE_MENU_ITEMS, so mobile renders two FAQ items.

Proposed fix
 const MOBILE_MENU_ITEMS = [
     { label: 'How it Works', href: '`#how-it-works`', icon: Layers },
     ...NAV_ITEMS,
-    { label: 'FAQ', href: '`#faq`', icon: CircleHelp }
 ];
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web-dashboard/src/pages/LandingPage/index.jsx` around lines 604 - 612,
The MOBILE_MENU_ITEMS array contains a duplicate FAQ entry. The FAQ item is
already included in MOBILE_MENU_ITEMS through the spread operator spreading
NAV_ITEMS (which contains the FAQ entry defined on line 604), and then it is
added again as a direct entry in the MOBILE_MENU_ITEMS array. Remove the
duplicate FAQ entry from the MOBILE_MENU_ITEMS array definition, keeping only
the spread of NAV_ITEMS and the How it Works entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@apps/web-dashboard/src/pages/LandingPage/index.jsx`:
- Around line 604-612: The MOBILE_MENU_ITEMS array contains a duplicate FAQ
entry. The FAQ item is already included in MOBILE_MENU_ITEMS through the spread
operator spreading NAV_ITEMS (which contains the FAQ entry defined on line 604),
and then it is added again as a direct entry in the MOBILE_MENU_ITEMS array.
Remove the duplicate FAQ entry from the MOBILE_MENU_ITEMS array definition,
keeping only the spread of NAV_ITEMS and the How it Works entry.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 12e92baa-e31a-4a7f-9f26-5250e713baed

📥 Commits

Reviewing files that changed from the base of the PR and between d9263c3 and 720dcca.

📒 Files selected for processing (1)
  • apps/web-dashboard/src/pages/LandingPage/index.jsx

@Nitin-kumar-yadav1307

Nitin-kumar-yadav1307 commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

@deepsikha-dash remove the duplicate FAQ in mobile menu , it renders two times , check coderabbit comment for more info

@yash-pouranik

Copy link
Copy Markdown
Member

@deepsikha-dash

@deepsikha-dash deepsikha-dash force-pushed the fix-326-add-faq-navbar branch from 720dcca to 146b29c Compare June 20, 2026 18:11
@Nitin-kumar-yadav1307 Nitin-kumar-yadav1307 merged commit 1a2073b into geturbackend:main Jun 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add FAQ navigation item that redirects users to the Common Questions section

3 participants