feat: add FAQ item to desktop navbar#330
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA FAQ entry ( FAQ Navigation Consolidation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web-dashboard/src/pages/LandingPage/index.jsx (1)
604-612:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRemove duplicated FAQ entry in mobile menu (root cause in menu composition).
Line 604 adds FAQ to
NAV_ITEMS, and Line 611 adds FAQ again inMOBILE_MENU_ITEMS, so mobile renders two FAQ items.Proposed fix
const MOBILE_MENU_ITEMS = [ { label: 'How it Works', href: '`#how-it-works`', icon: Layers }, ...NAV_ITEMS, - { label: 'FAQ', href: '`#faq`', icon: CircleHelp } ];🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web-dashboard/src/pages/LandingPage/index.jsx` around lines 604 - 612, The MOBILE_MENU_ITEMS array contains a duplicate FAQ entry. The FAQ item is already included in MOBILE_MENU_ITEMS through the spread operator spreading NAV_ITEMS (which contains the FAQ entry defined on line 604), and then it is added again as a direct entry in the MOBILE_MENU_ITEMS array. Remove the duplicate FAQ entry from the MOBILE_MENU_ITEMS array definition, keeping only the spread of NAV_ITEMS and the How it Works entry.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@apps/web-dashboard/src/pages/LandingPage/index.jsx`:
- Around line 604-612: The MOBILE_MENU_ITEMS array contains a duplicate FAQ
entry. The FAQ item is already included in MOBILE_MENU_ITEMS through the spread
operator spreading NAV_ITEMS (which contains the FAQ entry defined on line 604),
and then it is added again as a direct entry in the MOBILE_MENU_ITEMS array.
Remove the duplicate FAQ entry from the MOBILE_MENU_ITEMS array definition,
keeping only the spread of NAV_ITEMS and the How it Works entry.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 12e92baa-e31a-4a7f-9f26-5250e713baed
📒 Files selected for processing (1)
apps/web-dashboard/src/pages/LandingPage/index.jsx
|
@deepsikha-dash remove the duplicate FAQ in mobile menu , it renders two times , check coderabbit comment for more info |
720dcca to
146b29c
Compare
🚀 Pull Request Description
Fixes #326
🛠️ Type of Change
🧪 Testing & Validation
Backend Verification:
npm testin thebackend/directory and all tests passed.Frontend Verification:
npm run lintin thefrontend/directory.📸 Screenshots / Recordings (Optional)
Added a dedicated FAQ item to the desktop navigation bar. Clicking the item smoothly navigates users to the existing Common Questions section. The current design and responsiveness are preserved.


✅ Checklist
Built with ❤️ for urBackend.
Summary by CodeRabbit
New Features
Bug Fixes