[perminder-klair]

Summary

Merge after perminder-klair/subwave#1828 is in a release. Stations on an older controller would install these two skills without their feed: the brief alone, telling the DJ to report items it never received.

 buildSkills()
   slug, label, brief, cooldown, window, context
+  cron          # 5 fields, or 6 with seconds (controller's SKILL_CRON_RE)
+  cronOnly      # true/false only; refused without a cron
+  cohosts       # true/false only
+  feed          # https only
+  feedMaxItems  # 1–50, only alongside a feed

• cron, cronOnly and cohosts were already read by the controller but dropped here, so a community cron: never reached a station. Each is now emitted, and an unusable value fails the build rather than silently installing a different skill.
• feed is how a catalog skill gets real data without code. On install it becomes the skill's own feed: line, and the station's loader generates the fetch tool.
• The Add a skill issue form takes a feed. It has optional Feed URL and Feed items to read inputs. The submission workflow validates them with the builder's rules and writes them into the generated SKILL.md. A generated PR for a feed skill opens with a "Reads a feed" note naming the URL for the reviewer. The station's Share to community button (feat(controller): let community catalog skills carry a feed perminder-klair/subwave#1828) prefills both inputs.
• Two new skills:

skills/
├── music-press/   # Pitchfork news → one story: releases/tours/reunions; skips lawsuits/feuds; a death handled with care
└── good-news/     # Good News Network → one concrete good story; skips roundups/promos/opinion

Both speak only from fetched items and stay silent when nothing fits. The sources were picked by reading the live feeds: Consequence carries Prime Day deal posts, NME and Stereogum lean on controversy and opinion, and Positive News is mostly promos and essays.

Evidence

• node scripts/build-catalog.mjs --check → ✓ catalog valid (skills=11 …). The only warning is Trevor's, which predates this PR. Emitted entries:

  { "slug": "music-press", "label": "Music press bulletin", "cooldown": "3h",
    "feed": "https://pitchfork.com/feed/feed-news/rss", "feedMaxItems": 10 }

• Builder rules against a scratch copy with bad entries: all 7 refused, and a valid cron + cronOnly + cohosts entry passes.

  cohosts must be true or false (is "yes")
  feedMaxItems must be a whole number from 1 to 50 (is "99")
  cron "0 17 *" must be 5 fields, or 6 with seconds
  feed "http://example.com/rss" must be an https:// URL
  feed "not a url" is not a URL
  cronOnly needs a cron — without one the skill would never air
  feedMaxItems needs a feed
  

• End to end, with #1828 and this branch's built catalog on an isolated station: installing music-press from the admin Community modal wrote feed: + feedMaxItems:. Its generated tool returned live Pitchfork headlines.
• Form workflow: I ran the build-pr script locally from the YAML with a mocked GitHub API, using six issue bodies:

  feed-ok      https feed + 12 items → feed:/feedMaxItems: written, PR body flags the feed, builder accepts
  no-feed      → no feed lines, no flag (unchanged output)
  feed-http    → "Feed URL must start with https://"
  feed-space   → "Feed URL must be a single URL of up to 500 characters"
  count-alone  → "Feed items to read needs a Feed URL"
  count-big    → "Feed items to read must be a whole number from 1 to 50"
  

  Unquoted URLs with ?, &, #, ,, {} and ' all round-trip through the station's YAML frontmatter parser.
• Not yet tested: the briefs have not been run through a model.

Merge Danger

Door: two-way

Removing the skills or reverting the builder takes effect on the next catalog rebuild. Stations that already installed a skill keep their copy, as with any catalog entry.

Blast Radius: catalog-wide

• The builder now fails on cron/cronOnly/cohosts/feed values it used to ignore. No existing entry uses them, so the current catalog still builds.
• A form-submitted feed makes every installing station fetch a contributor-chosen URL. It is https-only, flagged in the generated PR for review, and shown to operators before install.