ref(workerchild): move checking future completion into bg thread#727
Merged
Conversation
untitaker
approved these changes
Jun 23, 2026
untitaker
left a comment
Member
There was a problem hiding this comment.
cursor comment seems legit, but rubberstamping otherwise
f180a08 to
04b0503
Compare
04b0503 to
b7e2223
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b7e2223. Configure here.
b7e2223 to
b377335
Compare
b377335 to
3692b7d
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously, future completion was only checked at the start of the worker child loop. A common pattern we saw was:
This didn't affect task throughput (since checking doneness is non-blocking), but did mean tasks would sometime exceed their processing deadline which is bad.
This PR tries to deal with that by moving this logic into a separate thread in the worker child.