ref(eap-items): use ConditionFunctions.EQ in IndexedNameOptimizer#8075
Merged
phacops merged 1 commit intoJun 19, 2026
Merged
Conversation
Address review nit: reference the ConditionFunctions.EQ constant rather than the hardcoded "equals" string in IndexedNameOptimizer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CajnvSCYTxvJ9Hw5jELRPH
phacops
merged commit 10147ea
into
feat/eap-items-indexed-name-filter-optimizer
27 of 28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses @MeredithAnya's review nit on #8052: in
IndexedNameOptimizer._indexed_name_key, reference theConditionFunctions.EQconstant instead of the hardcoded"equals"string when matching theitem_typeequality condition.This is a no-op behaviorally (
ConditionFunctions.EQ == "equals"); it just keeps the processor consistent with the rest of the query layer.This PR is stacked on top of
feat/eap-items-indexed-name-filter-optimizer(#8052), so the diff contains only the nit fix.🤖 Generated with Claude Code
Generated by Claude Code