Skip to content

Replace RowBinary serializer with clickhouse-crate inserter sink [EAP-584] #8063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phacops wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Replace RowBinary serializer with clickhouse-crate inserter sink [EAP-584] #8063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
827232f
feat(eap-items): insert via the official clickhouse crate inserter
claude Jun 18, 2026
125884e
fix(eap-items): fail-stop the inserter actor and bound join timeout
claude Jun 18, 2026
11ecada
feat(eap-items): retry transient insert errors with backoff
claude Jun 18, 2026
68f0c3c
fix(eap-items): assert flush count equals retained window in emit_ready
claude Jun 18, 2026
ab7d324
fix(eap-items): drain late flush outcomes on join timeout
claude Jun 18, 2026
411c894
fix(eap-items): disable crate validation for the JSON attributes_arra…
claude Jun 18, 2026
e80e837
fix(eap-items): enable native-tls so secure ClickHouse clusters work
claude Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 156 additions & 1 deletion rust_snuba/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions rust_snuba/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@ anyhow = { version = "1.0.69", features = ["backtrace"] }
cadence = "1.0.0"
chrono = { version = "0.4.26", features = ["serde"] }
cityhash-rs = "1.0.1"
clickhouse = { version = "0.15", default-features = false, features = [
"inserter",
"lz4",
"uuid",
# TLS for `secure: true` clusters (https URLs). native-tls matches the
# existing reqwest-based writer (OpenSSL + system roots), and openssl-sys is
# already pulled in by reqwest, so this adds no new system dependency.
"native-tls",
] }
Comment thread
cursor[bot] marked this conversation as resolved.
ctrlc = { version = "3.2.5", features = ["termination"] }
data-encoding = "2.5.0"
futures = "0.3.21"
Expand Down
2 changes: 1 addition & 1 deletion rust_snuba/rust-toolchain.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
[toolchain]
channel = "1.88.0"
channel = "1.94.1"
Loading
Loading