Skip to content

fix(prebuilt-dashboards): Allow feature gating prebuilt dashboards - #123909

Merged
DominikB2014 merged 3 commits into
masterfrom
narsaynorath/browse-729-block-feature-gated-prebuilt-dashboards-from-creation-until
Sep 9, 2026
Merged

fix(prebuilt-dashboards): Allow feature gating prebuilt dashboards#123909
DominikB2014 merged 3 commits into
masterfrom
narsaynorath/browse-729-block-feature-gated-prebuilt-dashboards-from-creation-until

Conversation

@narsaynorath

@narsaynorath narsaynorath commented Sep 9, 2026

Copy link
Copy Markdown
Member

The Node.js Runtime Metrics prebuilt dashboard relies on tracemetrics widgets. tracemetrics widgets are behind their own feature flag at the moment (tracemetrics-enabled)

This prevents us from enabling prebuilt dashboards for AM1 users that do not have the tracemetrics-enabled flag at the moment since they will have a dashboard that would always have no data, which is not a great user experience.

This PR adds a required_feature_flags check which should be used to list any flags that are relevant for the totality of the dashboard so users don't get something that won't be usable.

@narsaynorath
narsaynorath requested a review from a team as a code owner September 9, 2026 15:06
@linear-code

linear-code Bot commented Sep 9, 2026

Copy link
Copy Markdown

BROWSE-729

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 9, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 47743c6. Configure here.

Comment thread src/sentry/dashboards/endpoints/organization_dashboards.py Outdated
Comment thread src/sentry/dashboards/endpoints/organization_dashboards.py Outdated
Comment thread src/sentry/dashboards/endpoints/organization_dashboards.py Outdated
Comment thread src/sentry/dashboards/endpoints/organization_dashboards.py
Comment thread src/sentry/dashboards/endpoints/organization_dashboards.py
@DominikB2014
DominikB2014 merged commit 2fa5341 into master Sep 9, 2026
67 checks passed
@DominikB2014
DominikB2014 deleted the narsaynorath/browse-729-block-feature-gated-prebuilt-dashboards-from-creation-until branch September 9, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants