Skip to content

[DRAFT] typing: remove query_builder from mypy typing-issues list - #123894

Draft
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-module-cleanup-8f70
Draft

[DRAFT] typing: remove query_builder from mypy typing-issues list#123894
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-module-cleanup-8f70

Conversation

@cursor

@cursor cursor Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove sentry.snuba.metrics.query_builder from the tool.mypy.overrides "sentry modules with typing issues" list in pyproject.toml
  • fix all resulting mypy issues in src/sentry/snuba/metrics/query_builder.py by tightening type narrowing around action-by fields, guarding optional interval/op cases, and normalizing parameter typing with explicit casts
  • keep behavior intact while making the module pass type checks without the temporary error-code disable list

Testing

  • PYTHONPATH=/workspace/src PATH="/workspace/.venv/bin:$PATH" .venv/bin/python -m tools.mypy_helpers.mypy_without_ignores src/sentry/snuba/metrics/query_builder.py
  • PYTHONPATH=/workspace/src PATH="/workspace/.venv/bin:$PATH" .venv/bin/mypy --config-file pyproject.toml src/sentry/snuba/metrics/query_builder.py
  • PYTHONPATH=/workspace/src PATH="/workspace/.venv/bin:$PATH" .venv/bin/python -m tools.mypy_helpers.check_stronglist pyproject.toml
  • PYTHONPATH=/workspace/src PATH="/workspace/.venv/bin:$PATH" .venv/bin/prek run -q
  • PYTHONPATH=/workspace/src PATH="/workspace/.venv/bin:$PATH" .venv/bin/pytest -n3 -svv --reuse-db tests/sentry/test_mypy_stronglist.py (fails in this VM due missing local Redis/devservices: ConnectionRefusedError: localhost:6379)

@armenzg could you review this draft when you have a chance?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Open in Web View Automation 

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant