Skip to content

fix(storybook): Prevent Slot.Consumer error in investigations stories #123887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sentry wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −12
Draft

fix(storybook): Prevent Slot.Consumer error in investigations stories #123887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions static/app/views/investigations/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {Container} from '@sentry/scraps/layout';
import * as Storybook from 'sentry/stories';
import InvestigationsView, {InvestigationsPage} from 'sentry/views/investigations';
import {InvestigationListItemFixture} from 'sentry/views/investigations/fixtures';
import {TopBar} from 'sentry/views/navigation/topBar';
import {getPaginationPageLink} from 'sentry/views/organizationStats/utils';

import {InvestigationFixtureApi} from './__stories__/investigationFixtureApi';
Expand Down Expand Up @@ -64,17 +65,21 @@ export default Storybook.story('Investigations — List', story => {
list={realisticInvestigations}
pageLinks={getPaginationPageLink({numRows: 14, pageSize: 5, offset: 0})}
>
<Container minHeight="520px" border="primary" radius="md" overflow="hidden">
<InvestigationsPage />
</Container>
<TopBar.Slot.Provider>
<Container minHeight="520px" border="primary" radius="md" overflow="hidden">
<InvestigationsPage />
</Container>
</TopBar.Slot.Provider>
</InvestigationFixtureApi>
));

story('Empty and search results', () => (
<InvestigationFixtureApi organizationSlug="storybook-investigations-empty" list={[]}>
<Container minHeight="420px" border="primary" radius="md" overflow="hidden">
<InvestigationsPage />
</Container>
<TopBar.Slot.Provider>
<Container minHeight="420px" border="primary" radius="md" overflow="hidden">
<InvestigationsPage />
</Container>
</TopBar.Slot.Provider>
</InvestigationFixtureApi>
));

Expand All @@ -83,9 +88,11 @@ export default Storybook.story('Investigations — List', story => {
organizationSlug="storybook-investigations-list-loading"
mode="loading"
>
<Container minHeight="420px" border="primary" radius="md" overflow="hidden">
<InvestigationsPage />
</Container>
<TopBar.Slot.Provider>
<Container minHeight="420px" border="primary" radius="md" overflow="hidden">
<InvestigationsPage />
</Container>
</TopBar.Slot.Provider>
</InvestigationFixtureApi>
));

Expand All @@ -94,9 +101,11 @@ export default Storybook.story('Investigations — List', story => {
organizationSlug="storybook-investigations-list-error"
mode="error"
>
<Container minHeight="420px" border="primary" radius="md" overflow="hidden">
<InvestigationsPage />
</Container>
<TopBar.Slot.Provider>
<Container minHeight="420px" border="primary" radius="md" overflow="hidden">
<InvestigationsPage />
</Container>
</TopBar.Slot.Provider>
</InvestigationFixtureApi>
));

Expand Down
Loading