Skip to content

feat(onboarding): Add Remix 2.x support | remove 1.x support #123882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JPeer264 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −6
Draft

feat(onboarding): Add Remix 2.x support | remove 1.x support #123882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions static/app/gettingStartedDocs/javascript-remix/onboarding.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@ describe('javascript-remix onboarding docs', () => {
).toBeInTheDocument();
});

it('documents the supported Remix version', () => {
renderWithOnboardingLayout(docs);

expect(
screen.getByText(textWithMarkupMatcher(/supports Remix 2\.x/))
).toBeInTheDocument();
});

it('has metrics onboarding configuration', () => {
expect(docs.metricsOnboarding).toBeDefined();
expect(docs.metricsOnboarding?.install).toBeDefined();
Expand Down
9 changes: 3 additions & 6 deletions static/app/gettingStartedDocs/javascript-remix/onboarding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,9 @@ import {getInstallContent} from './utils';
export const onboarding: OnboardingConfig = {
introduction: () => (
<p>
{tct(
"Sentry's integration with [remixLink:Remix] supports Remix 1.0.0 and above.",
{
remixLink: <ExternalLink href="https://remix.run/" />,
}
)}
{tct("Sentry's integration with [remixLink:Remix] supports Remix 2.x.", {
remixLink: <ExternalLink href="https://remix.run/" />,
})}
</p>
),
install: (params: DocsParams) => [
Expand Down
Loading