chore(orchanizations): remove the new_id dual write and make the column nullable - #123856
Merged
Merged
Conversation
The pk swap has landed, so the machinery that kept the shadow column equal to the id is dead weight; inserts now let the identity generate the id. The column is only marked pending here, since dropping it for real needs its own deploy.
The swap is deployed and its migration is frozen, so the test can no longer fail in a way anyone would act on.
github-actions
Bot
added
the
Scope: Backend
markstory
approved these changes
Sep 9, 2026
…remove-new-id-dual-write # Conflicts: # migrations_lockfile.txt
Master landed 1165 and 1166 while this was open.
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Alter field new_id on organizationmemberteam
--
ALTER TABLE "sentry_organizationmember_teams" ALTER COLUMN "new_id" DROP NOT NULL;
--
-- Moved organizationmemberteam.new_id field to pending deletion state
--
-- (no-op) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs INFRENG-450.
Step 6 of the column widening, code cleanups and prepare for the column to be dropped