ref(hybridcloud): Register webhook worker threads at the deployed value - #123716
Open
vaind wants to merge 2 commits into
Open
ref(hybridcloud): Register webhook worker threads at the deployed value#123716vaind wants to merge 2 commits into
vaind wants to merge 2 commits into
Conversation
The automator has set `hybridcloud.webhookpayload.worker_threads` to 16 for every environment since #928 in March 2024, so the registered 4 has not been the number any deploy runs for over two years. Reading the registration told you the wrong thing, and the value cannot be dropped from the automator while the two disagree — unsetting it would quietly quarter the delivery concurrency. Production is unchanged: the automator value wins and is identical. An environment with no automator entry, self-hosted included, moves from 4 to 16, bounded by the records a claim actually holds and only for skip-on-failure providers; strict providers keep delivering on one thread.
github-actions
Bot
added
the
Scope: Backend
The line about strict providers repeated what the skip_on_failure_providers comment two registrations below already says.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hybridcloud.webhookpayload.worker_threadscaps how many threads a webhook drain delivers on. The code registers4; every deployed environment has run16since automator#928 in March 2024. This registers16.Production is unchanged — the automator value wins, and it is the value being registered. What the mismatch cost:
defaults.pynamed a concurrency nobody runs, and the automator entry could not be dropped while4was the fallback, since unsetting it would quarter delivery concurrency with no code change.An environment with no automator entry — self-hosted, or a region that never got one — goes from 4 threads to 16. A drain uses
min(worker_threads, records claimed)threads, and only for skip-on-failure providers; strict providers deliver on one thread regardless.The option stays registered: thread count is a real knob, and #123449 makes it load-bearing in mailbox sizing. Next is the automator dropping four now-redundant entries, all holding
16, once this has deployed everywhere.Verification:
tests/sentry/hybridcloud/tasks/test_deliver_webhooks.py147 passed,prek run -qclean.Fixes CW-1827