fix(discover): Prevent homepage crash on unmapped dataset param - #123707
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(discover): Prevent homepage crash on unmapped dataset param#123707sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a
TypeError: Cannot read properties of undefined (reading 'environment')that occurred on/explore/discover/homepage/.Root Cause:
When
hasDatasetSelectoris enabled and no saved homepage query exists,checkEventViewinstatic/app/views/discover/results.tsxattempts to get a default event view usingDEFAULT_EVENT_VIEW_MAP[value]. If thevalue(derived from the URL's?dataset=parameter) does not correspond to one of the few keys inDEFAULT_EVENT_VIEW_MAP(e.g.,DISCOVER,ERRORS,TRANSACTIONS), the lookup returnsundefined. Thisundefinedthen propagates throughgetSavedQueryWithDataset(undefined)and is passed as thenewQueryargument toEventView.fromNewQueryWithLocation, causing a crash whennewQuery.environmentis accessed.Fix:
Added a nullish coalescing operator (
?? DEFAULT_EVENT_VIEW) to theDEFAULT_EVENT_VIEW_MAP[value]lookup instatic/app/views/discover/results.tsx. This ensures that if an unrecognized dataset value is encountered, it gracefully falls back toDEFAULT_EVENT_VIEW, guaranteeing a validNewQueryobject is always passed toEventView.fromNewQueryWithLocation.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-38Z6
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.