fix(stats): Prevent crash when URL dataCategory is not chart-supported - #123706
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(stats): Prevent crash when URL dataCategory is not chart-supported#123706sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash on the organization stats page (
/stats/) when adataCategoryquery parameter is provided for a category that is not supported by the usage chart.Problem:
The
dataCategoryInfogetter instatic/app/views/organizationStats/index.tsxwould resolve thedataCategoryURL query parameter against all entries inDATA_CATEGORY_INFO. However, the usage chart'sCHART_OPTIONS_DATACATEGORYonly includes categories wherestatsInfo.showExternalStatsistrue. If a category likemonitorSeats(which hasshowExternalStats: false) was passed via the URL, the getter would successfully resolve it, but the chart would then fail to find it in its options, leading to anError: Selected item is not supported.Solution:
The
dataCategoryInfogetter has been updated to only consider categories wherestatsInfo.showExternalStatsistrue. This ensures that anydataCategoryprovided in the URL that is not chart-compatible will now correctly fall back to the default 'errors' category, preventing the crash.A regression test has been added to
static/app/views/organizationStats/index.spec.tsxto verify this behavior.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-39BX
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.