fix(redis): Support list types in RedisBuffer serialization - #123705
Draft
sentry[bot] wants to merge 2 commits into
Draft
fix(redis): Support list types in RedisBuffer serialization#123705sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
TypeError: <class 'list'>occurring insentry.tasks.store.save_eventwhenRedisBuffer._dump_valueattempts to serializeGroup.data.The root cause was that
RedisBuffer._dump_valuedid not have a specific branch to handle Pythonlisttypes. This became problematic whenGroup.data.metadata.seer_similarity.results(which is a list of dicts from Seer) was encountered during serialization, causing theelsebranch to raise aTypeError.This fix introduces
elif isinstance(value, list)branches in both_dump_valueand_load_valueto correctly serialize and deserialize list types, mirroring the existingdicthandling. Additionally, the return type annotation for_load_valueswas updated to includelist[Any]to resolve amypyerror.New test cases have been added to
test_dump_and_load_valueto cover both flat lists and lists of dictionaries, ensuring the new serialization logic works as expected.Fixes SENTRY-5SD4
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5SD4
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.