fix(issue-details): Don't show success notification on failure - #123672
Open
hobzcalvin wants to merge 4 commits into
Open
fix(issue-details): Don't show success notification on failure#123672hobzcalvin wants to merge 4 commits into
hobzcalvin wants to merge 4 commits into
Conversation
hobzcalvin
requested review from
natemoo-re and
priscilawebdev
and removed request for
a team and
natemoo-re
September 4, 2026 00:43
github-actions
Bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In resolve, delete, and feedback-delete, we had
completehandlers where we should havesuccesshandlers. Usingsuccessinstead (keeping some functionality incompletethat needs to run no matter what), failure is indicated properly, instead of the green-checkmark "Resolved" etc. I was seeing, even on failure.This was noted here: #112982 (comment) but must have gotten missed.
The related failure is fixed in #123671