Skip to content

ref(seer-agent): dont count empty result as failed status, remove broken link icon#118613

Open
aliu39 wants to merge 1 commit into
masterfrom
aliu/icon-fix
Open

ref(seer-agent): dont count empty result as failed status, remove broken link icon#118613
aliu39 wants to merge 1 commit into
masterfrom
aliu/icon-fix

Conversation

@aliu39

@aliu39 aliu39 commented Jun 26, 2026

Copy link
Copy Markdown
Member

interpreting empty result as a failure makes it look like our search tool is constantly breaking

Before (https://sentry.sentry.io/issues/?project=-1&statsPeriod=90d&explorerRunId=a129de61-005d-4d0f-991e-474d663c2841)
Screenshot 2026-06-26 at 4 46 50 PM

After
Screenshot 2026-06-26 at 4 46 25 PM

Kept
Screenshot 2026-06-26 at 4 46 59 PM

Removed on hover icon (used to show when there's no link, but this also looks like something broke)
Screenshot 2026-06-26 at 4 47 08 PM

@aliu39 aliu39 requested a review from a team as a code owner June 26, 2026 23:51
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 26, 2026
@aliu39 aliu39 requested a review from a team June 26, 2026 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant