fix(explore): Cap heat map unfurl grid to a fixed-density size#118598
Open
gggritso wants to merge 3 commits into
Open
fix(explore): Cap heat map unfurl grid to a fixed-density size#118598gggritso wants to merge 3 commits into
gggritso wants to merge 3 commits into
Conversation
Heat map unfurls render to a fixed 1200x400 Chartcuterie canvas, but the query builder picked the finest interval from a time-range ladder (e.g. 5m over 24h -> 288x96 = ~27.6k cells). That is ~24x denser than the live UI and trips ECharts' progressive-rendering threshold, so Chartcuterie's synchronous snapshot captures only the first few columns and the heat map renders squished into a thin left strip. Target a fixed-density grid sized to the canvas instead: pick the finest candidate interval that keeps columns within 150, and always request 50 value rows. 150x50 over 1200x400 yields ~8px square cells and a consistent density at every duration, matching the in-app UI far more closely. Fixes DAIN-1752 Refs DAIN-1740 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 29a7384. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were seeing some broken Heat Map unfurls, turns out there were two causes:
This PR fixes the first problem. On the backend side, the chart canvas dimensions are fixed, and we just care about having roughly the right amount of buckets. So, take the simple approach. Find an interval that produces roughly 150 buckets on the X-axis, and always render 50 buckets on the Y-axis. This should make it easy to compare charts in Slack unfurls, and keeps the code simple.
Fixes DAIN-1752, see also getsentry/chartcuterie#234