feat(issues): Add single line activity feed items#118571
Open
scttcper wants to merge 13 commits into
Open
Conversation
The v2 issue activity feed needs a flatter row layout while we iterate on the redesign. This adds a linear item renderer behind the existing feature flag with fixed progress markers, actor slots, compact copy, and note bubbles. The legacy activity path stays in place for flag-off orgs. Co-Authored-By: Codex <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff✅ no issues found |
Move the activity feed chips into their own folder so the compact activity copy does not depend on one big badges file. Also removes transient styled props from the new activity line row and chip frame. No more `$` props in this PR. Co-Authored-By: Codex <noreply@openai.com>
Move the activity line progress marker into its own folder with separate variant mapping and marker rendering. keeps the row cell wrapper tiny and makes the marker variants easier to iterate on. Co-Authored-By: Codex <noreply@openai.com>
The neutral activity marker started looking like a hollow progress ring after the lint token fix. Use an invisible background mask behind the small grey dot instead of a visible border, so it still covers the rail without changing the shape. Co-Authored-By: Codex <noreply@openai.com>
scttcper
changed the title
split the compact activity copy helpers into smaller files and switch the bigger helper calls over to object params. also gives the v2 activity feed its own list wrapper instead of leaning on Timeline.Container, and cleans up the lint/type coverage fallout from the first pass. Co-Authored-By: GPT-5 Codex <noreply@openai.com>
rename the old two-column flag variable now that the v2 path renders linear activity items. also removes stale marker assertions from the flagged tests and collapses the chip frame variants into props on one component. Co-Authored-By: GPT-5 Codex <noreply@openai.com>
Pull the v2 activity line into smaller row, body, layout, and note pieces. Notes now render from note data directly instead of going through the compact activity switch. Also share assignment integration labels between legacy and v2, and stop threading teams through the linear item props. Co-authored-by: OpenAI Codex <noreply@openai.com>
use the external issue label for the new activity chip, move regression comparison copy below the headline, and make note bubbles fill the row. also keeps assignment attribution regular weight. Co-authored-by: OpenAI Codex <noreply@openai.com>
show referenced commits as commit-created activity with a dedicated commit chip and the same progress marker as PR-created activity. also removes the chip barrel so the activity line imports the chip components directly. Co-authored-by: OpenAI Codex <noreply@openai.com>
# Conflicts: # static/app/views/issueDetails/activitySection/index.tsx
tighten up the v2 progress marker mapping and rename the muted quarter marker to routed so it matches how it is used. also gives assigned user chips an avatar from the assignment payload and fills in the missing compact copy types found during validation. Co-authored-by: OpenAI Codex <noreply@openai.com>
knip caught the compact commit link helper as an unused export. keep it local to the commit details helper instead. Co-authored-by: OpenAI Codex <noreply@openai.com>
split the assigned-to copy into separate flex items so the assignee chip can actually shrink in the sidebar. also adds a constrained compact chip variant so avatar-backed assignee chips truncate instead of pushing the row wider. Co-authored-by: OpenAI Codex <noreply@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 22af28b. Configure here.
| {t('View %s more', filteredActivities.length - 3)} | ||
| </LinkButton> | ||
| </Container> | ||
| </MoreActivityRow> |
Contributor
There was a problem hiding this comment.
View more row grid misaligned
Medium Severity
With issue-activity-feed-v2, each activity row uses a three-column grid (marker, actor, headline), but the sidebar “View more” row still uses two columns. The expand link and icon line up with the marker/actor columns instead of the headline text above.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 22af28b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new renderer for the v2 issue activity feed behind
organizations:issue-activity-feed-v2. It keeps the old timeline path for flag-off orgs and pulls the v2 pieces into focused item, marker, actor, badge, and compact-copy components. The designs aren't quite all the way there and the progress indicators will need to be refined quite a bit but this should unblock the other activity work taking placefigma