Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/sentry/options/defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -3108,6 +3108,14 @@
flags=FLAG_AUTOMATOR_MODIFIABLE,
)

# Enable sending raw bytes payload to taskbroker instead of base64 encoded
register(
"profiling.process.raw_bytes_payload.enabled",
default=False,
type=Bool,
flags=FLAG_AUTOMATOR_MODIFIABLE,
)

# Enable sending a post update signal after we update groups using a queryset update
register(
"groups.enable-post-update-signal",
Expand Down
7 changes: 5 additions & 2 deletions src/sentry/profiles/consumers/process/factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,11 @@ def process_message(message: Message[KafkaPayload]) -> None:
sampled = is_sampled(message.payload.headers)

if sampled or options.get("profiling.profile_metrics.unsampled_profiles.enabled"):
b64encoded = b64encode(message.payload.value).decode("utf-8")
process_profile_task.delay(payload=b64encoded, sampled=sampled)
if options.get("profiling.process.raw_bytes_payload.enabled"):
process_profile_task.delay(payload=message.payload.value, sampled=sampled)
else:
encoded = b64encode(message.payload.value).decode("utf-8")
process_profile_task.delay(payload=encoded, sampled=sampled)


class ProcessProfileStrategyFactory(ProcessingStrategyFactory[KafkaPayload]):
Expand Down
7 changes: 5 additions & 2 deletions src/sentry/profiles/task.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,15 +141,18 @@ def encode_payload(message: dict[str, Any]) -> str:
)
def process_profile_task(
profile: Profile | None = None,
payload: str | None = None,
payload: bytes | str | None = None,
sampled: bool = True,
**kwargs: Any,
) -> None:
if not sampled and not options.get("profiling.profile_metrics.unsampled_profiles.enabled"):
return

if payload:
message_dict = msgpack.unpackb(b64decode(payload.encode("utf-8")), use_list=False)
# Handle both bytes (new) and base64 string (legacy) payloads
if isinstance(payload, str):
payload = b64decode(payload.encode("utf-8"))
message_dict = msgpack.unpackb(payload, use_list=False)

profile = json.loads(message_dict["payload"], use_rapid_json=True)

Expand Down
3 changes: 3 additions & 0 deletions tests/sentry/processing/backpressure/test_checking.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"backpressure.checking.interval": 5,
"backpressure.monitoring.enabled": False,
"backpressure.status_ttl": 60,
"profiling.process.raw_bytes_payload.enabled": False,
}
)
def test_bad_config() -> None:
Expand All @@ -44,6 +45,7 @@ def test_bad_config() -> None:
"backpressure.checking.interval": 5,
"backpressure.monitoring.enabled": True,
"backpressure.status_ttl": 60,
"profiling.process.raw_bytes_payload.enabled": False,
}
)
def test_backpressure_healthy_profiles(process_profile_task: MagicMock) -> None:
Expand Down Expand Up @@ -112,6 +114,7 @@ def test_backpressure_healthy_events(preprocess_event: MagicMock) -> None:
{
"backpressure.checking.enabled": False,
"backpressure.checking.interval": 5,
"profiling.process.raw_bytes_payload.enabled": False,
}
)
def test_backpressure_not_enabled(process_profile_task: MagicMock) -> None:
Expand Down
Loading