Skip to content

chore: Fix Apple CODEOWNERS path - #1379

Merged
christophaigner merged 1 commit into
masterfrom
chore/codeowners-apple-path
Oct 27, 2026
Merged

christophaigner merged 1 commit into
masterfrom
chore/codeowners-apple-path

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Changes the only rule in .github/CODEOWNERS from ./src/apple/* to /src/apple/. It's still owned by @getsentry/team-mobile-apple-sdk.

The old pattern had two problems:

  • CODEOWNERS patterns use gitignore-style paths, and anchoring to the repo root is done with a leading /, not ./. The ./ form most likely never matched.
  • * doesn't cross directory boundaries, so even a matching src/apple/* would have missed src/apple/snapshots/.

/src/apple/ covers everything under src/apple/. The Apple team has maintain access on this repo, so GitHub can request its review.

Part of the Mobile SDK team migration to per-platform GitHub teams. This PR only touches the Apple rule.

via Chris Aigner.

--

View Junior Session [Sentry]

Co-Authored-By: Chris Aigner <christoph.aigner@sentry.io>
@christophaigner
christophaigner enabled auto-merge (squash) October 27, 2026 12:53
@christophaigner
christophaigner merged commit 181cdcd into master Oct 27, 2026
59 checks passed
@christophaigner
christophaigner deleted the chore/codeowners-apple-path branch October 27, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant