feat: New set_attribute api#2998
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
sl0thentr0py
force-pushed
the
neel/set-attribute
branch
from
35089a2 to
0185e4e
Compare
sl0thentr0py
force-pushed
the
neel/set-attribute
branch
from
0185e4e to
c5c0ad9
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c5c0ad9. Configure here.
dingsdax
reviewed
Jun 30, 2026
dingsdax
approved these changes
Jun 30, 2026
dingsdax
left a comment
dingsdax
left a comment
Contributor
There was a problem hiding this comment.
nice one 👏 ; one small performance consideration
set_attribute(key, value, unit: nil) set_attributes(attributes_hash) remove_attribute(key) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AtcJFmXABtrEgpwngfZxq5
sl0thentr0py
force-pushed
the
neel/set-attribute
branch
from
c5c0ad9 to
867fd59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the spec at https://develop.sentry.dev/sdk/foundations/state-management/scopes/attributes/
set_attribute(key, value, unit: nil)set_attributes(attributes_hash)remove_attribute(key)Issues
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com