Skip to content

ci: reduce sample app build matrix to production-only - #6687

Open
alwx wants to merge 2 commits into
mainfrom
alwx/ci/sample-app-production-only-builds
Open

ci: reduce sample app build matrix to production-only#6687
alwx wants to merge 2 commits into
mainfrom
alwx/ci/sample-app-production-only-builds

Conversation

@alwx

@alwx alwx commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Removes dev builds from the sample app CI matrix where they provide no unique signal.

Job Before After
bare RN macOS dev + production production only
Expo iOS (no-frameworks + dynamic-frameworks) dev + production production only
Expo Android dev + production production only

Not changed: bare RN iOS (has xcframework/cocoapods dimension) and bare RN Android (dev build is the only guard for the #6398 ABI-filter regression).

Trade-off: dev-mode regressions are no longer caught in CI — they'll surface locally when running the sample app in dev mode.

💡 Motivation and Context

Closes #5770.

💚 How did you test it?

Matrix change only — verified by diffing the workflow files. No logic changed.

📝 Checklist

  • I added tests to verify changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing.
  • No breaking changes.

🔮 Next steps

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • ci: reduce sample app build matrix to production-only by alwx in #6687
  • test(e2e): Evaluate replay assertion on Android by antonis in #6684
  • test(e2e): Restore iOS replay assertion in captureReplay test by antonis in #6683
  • feat(visionos): Add visionOS sample app by antonis in #6676
  • fix(core): Align beforeBreadcrumb and tracesSampler error fallbacks with spec by antonis in #6675
  • chore(replay): Mark mobileReplayIntegration as stable by antonis in #6679
  • feat(sample): Add tvOS sample app by antonis in #6677
  • fix(e2e): Pin json gem < 3.0 for RN < 0.72 iOS builds by antonis in #6678
  • feat(ios): Expose enableMemoryIntrospection option by antonis in #6674
  • feat(android): Add anrProfilingSampleRate option by antonis in #6673
  • ci: Unpin Android E2E emulator build by antonis in #6672
  • ref(ios): Remove deprecated private SDK API usage by philprime in #6647
  • chore(deps): update Cocoa SDK to v9.27.0 by github-actions in #6670
  • chore(deps): update Sentry Android Gradle Plugin to v6.21.0 by github-actions in #6671
  • chore(deps): Bump fast-uri to ^3.1.6 to resolve security alerts by antonis in #6662
  • chore(deps): Bump qs to ^6.16.0 to resolve security alerts by antonis in #6663
  • chore(deps): Bump @xmldom/xmldom pins to patched versions to resolve security alerts by antonis in #6664
  • docs: Revamp root and nested AGENTS.md by antonis in #6666

🤖 This preview updates automatically when you update the PR.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor
Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 8beab64

@alwx
alwx marked this pull request as ready for review September 9, 2026 13:49
@alwx
alwx requested review from a team, antonis and lucas-zimerman as code owners September 9, 2026 13:49
Comment thread CHANGELOG.md Outdated
@alwx
alwx force-pushed the alwx/ci/sample-app-production-only-builds branch from 19cb5a8 to f0af8a5 Compare September 9, 2026 14:10
@alwx
alwx requested a review from antonis September 9, 2026 14:14
# support in 9.20.0, so the source-build fallback
# (`SENTRY_USE_XCFRAMEWORK=0`) can no longer resolve newer versions
# and is not exercised here.
build-type: ["production"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android dev (bare RN) — kept: it's the only guard for the #6398 ABI-filter regression (builds arm64-v8a only + runs check-tm-perf-logger-abi-subset.sh). No equivalent check in the production job.

What do you think of keeping this too?
Similar to the reasoning on keeping the Android dev build below we should keep one dev build for iOS too. As a dev tool we should guard that the sdk builds with metro in development and xcode debug config etc

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said we can strip the dev mode in the recently added vision os and tvos and keep only the bare ios

Comment thread .github/workflows/sample-application.yml Outdated

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Left a comment to discuss further

Drop dev builds from iOS, macOS, visionOS, tvOS (bare RN) and all
platforms (Expo). Android dev build is kept — it's the only guard for
the #6398 ABI-filter regression (arm64-v8a subset + perf-logger check).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@alwx
alwx force-pushed the alwx/ci/sample-app-production-only-builds branch from f0af8a5 to 627dce5 Compare September 9, 2026 14:17
@alwx
alwx requested a review from antonis September 9, 2026 14:21

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If you agree we can also remove tvos and visionos dev builds here or in a follow up PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample applications: production-only builds

2 participants