Skip to content

ref(starlette): Add package to typing group#6728

Merged
alexander-alderman-webb merged 8 commits into
masterfrom
webb/starlette/types
Jul 2, 2026
Merged

ref(starlette): Add package to typing group#6728
alexander-alderman-webb merged 8 commits into
masterfrom
webb/starlette/types

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

Add starlette to the typing dependencies and resolve errors.

sentry_sdk/integrations/mcp.py:58: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:48: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:50: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:51: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:54: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:55: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:58: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:59: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:60: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:67: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:425: error: Argument 2 has incompatible type "type"; expected "_MiddlewareFactory[[VarArg(Any), KwArg(Any)]]"  [arg-type]
sentry_sdk/integrations/starlette.py:425: note: "_MiddlewareFactory[[VarArg(Any), KwArg(Any)]].__call__" has type "def __call__(self, Callable[[Any, Callable[[], Awaitable[Any]], Callable[[Any], Awaitable[None]]], Awaitable[None]], /, *Any, **Any) -> Callable[[Any, Callable[[], Awaitable[Any]], Callable[[Any], Awaitable[None]]], Awaitable[None]]"
sentry_sdk/integrations/starlette.py:433: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/starlette.py:465: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/starlette.py:665: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/starlette.py:695: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/starlette.py:704: error: Incompatible types in assignment (expression has type "None", variable has type "Request[State]")  [assignment]

Issues

Reminders

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

90048 passed | ⏭️ 6298 skipped | Total: 96346 | Pass Rate: 93.46% | Execution Time: 318m 3s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2438 uncovered lines.
✅ Project coverage is 89.77%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.77%    89.77%        —%
==========================================
  Files          192       192         —
  Lines        23824     23823        -1
  Branches      8226      8226         —
==========================================
+ Hits         21386     21385        -1
- Misses        2438      2438         —
- Partials      1349      1349         —

Generated by Codecov Action

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review July 2, 2026 09:48
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner July 2, 2026 09:48
@alexander-alderman-webb alexander-alderman-webb merged commit 984290d into master Jul 2, 2026
272 of 274 checks passed
@alexander-alderman-webb alexander-alderman-webb deleted the webb/starlette/types branch July 2, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants