Skip to content

ci(mcp): Pin mcp package to <2.0.0 while alphas are in flight #6687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericapisani merged 1 commit into from
Jun 29, 2026
Merged

ci(mcp): Pin mcp package to <2.0.0 while alphas are in flight #6687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/populate_tox/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@
"deps": {
"*": ["pytest-asyncio"],
},
"include": "<2.0.0", # Alphas are currently being released, will come back to these before the release that's expected at the end of July 2026

@sentry sentry Bot Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The include: "<2.0.0" specifier for mcp will not prevent testing against pre-release versions like 2.0.0a1 due to PEP 440 version comparison rules.
Severity: MEDIUM

Suggested Fix

To correctly exclude specific pre-release versions, use inequality specifiers. For example, change the include value to something like "!=2.0.0a1,!=2.0.0a2" to explicitly filter out known alpha versions, similar to how the starlite integration is configured.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: scripts/populate_tox/config.py#L306

Potential issue: The configuration change for the `mcp` integration uses `"include":
"<2.0.0"` with the intent to skip testing against `2.0.0-alpha` versions. However, this
will not work as expected. According to PEP 440, a pre-release version like `2.0.0a1` is
considered less than `2.0.0`. Since the `SpecifierSet` in `_prefilter_releases` is
created with `prereleases=True`, `2.0.0a1` will pass the `include_versions` filter. The
script will then identify it as the latest pre-release and may select it for testing,
which is contrary to the stated goal of the change.

Did we get this right? 👍 / 👎 to inform future reviews.

},
"fastmcp": {
"package": "fastmcp",
Expand Down
Loading