feat: Set sentry.trace_lifecycle attr in span streaming#6684
Merged
Conversation
sentry.trace_lifecycle attr in span streaming
Contributor
Codecov Results 📊✅ 90151 passed | ⏭️ 6305 skipped | Total: 96456 | Pass Rate: 93.46% | Execution Time: 324m 22s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2399 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.95% 89.92% -0.03%
==========================================
Files 192 192 —
Lines 23809 23809 —
Branches 8218 8218 —
==========================================
+ Hits 21418 21410 -8
- Misses 2391 2399 +8
- Partials 1337 1338 +1Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Jun 29, 2026
ericapisani
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sentry.trace_lifecyclewas added to common span attrs: https://develop.sentry.dev/sdk/telemetry/spans/span-protocol/#common-attribute-keys Add it to the SDK.And: don't test for irrelevant attrs in integration tests.
Issues
Closes https://linear.app/getsentry/issue/PY-2564/add-sentrytrace-lifecycle-attribute
Reminders
uv run ruff.feat:,fix:,ref:,meta:)