Skip to content

feat: Set sentry.trace_lifecycle attr in span streaming#6684

Merged
sentrivana merged 5 commits into
masterfrom
ivana/trace-lifecycle-attr
Jun 29, 2026
Merged

feat: Set sentry.trace_lifecycle attr in span streaming#6684
sentrivana merged 5 commits into
masterfrom
ivana/trace-lifecycle-attr

Conversation

@sentrivana

@sentrivana sentrivana commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

sentry.trace_lifecycle was added to common span attrs: https://develop.sentry.dev/sdk/telemetry/spans/span-protocol/#common-attribute-keys Add it to the SDK.

And: don't test for irrelevant attrs in integration tests.

Issues

Closes https://linear.app/getsentry/issue/PY-2564/add-sentrytrace-lifecycle-attribute

Reminders

@linear-code

linear-code Bot commented Jun 29, 2026

Copy link
Copy Markdown

PY-2564

@sentrivana sentrivana changed the title feat: Set sentry.trace_lifecycle attr in span streaming feat: Set sentry.trace_lifecycle attr in span streaming Jun 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

90151 passed | ⏭️ 6305 skipped | Total: 96456 | Pass Rate: 93.46% | Execution Time: 324m 22s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests 📈 +29
Failed Tests 📉 -29
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2399 uncovered lines.
❌ Project coverage is 89.92%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    89.95%    89.92%    -0.03%
==========================================
  Files          192       192         —
  Lines        23809     23809         —
  Branches      8218      8218         —
==========================================
+ Hits         21418     21410        -8
- Misses        2391      2399        +8
- Partials      1337      1338        +1

Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review June 29, 2026 12:18
@sentrivana sentrivana requested a review from a team as a code owner June 29, 2026 12:18
@sentrivana sentrivana merged commit 1dd161d into master Jun 29, 2026
144 checks passed
@sentrivana sentrivana deleted the ivana/trace-lifecycle-attr branch June 29, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants