Skip to content

feat(cloud_resource_context): Support span streaming #6550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexander-alderman-webb wants to merge 1 commit into from
Closed

feat(cloud_resource_context): Support span streaming #6550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sentry_sdk/integrations/cloud_resource_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import urllib3

import sentry_sdk
from sentry_sdk.api import set_context
from sentry_sdk.integrations import Integration
from sentry_sdk.utils import logger
Expand Down Expand Up @@ -262,6 +263,8 @@ def setup_once() -> None:
context = CloudResourceContextIntegration._get_cloud_resource_context()
if context != {}:
set_context(CONTEXT_TYPE, context)
for k, v in context.items():
sentry_sdk.get_isolation_scope().set_attribute(k, v)

@sentrivana sentrivana Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will set the attributes on all spans. Given that they're not in the common attrs list, they should probably be set on the segment of the current span instead?

@alexander-alderman-webb alexander-alderman-webb Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the attributes should be on the segment span.
Now I look at this, I'm not sure how that would work because the context is set in setup_once().
I guess we would need some mechanism to set attributes on a scope that are then only applied on the segment span.
Alternatively, we consider not migrating the integration to span first.

@sentrivana sentrivana Jun 10, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, missed that we're in setup_once here.

I would leave this integration out for now. I believe it'd make sense for this to live in the aws/gcp integrations eventually, but as is, I'd not migrate. Errors will still get the context and that's probably where it's most useful.



# Map with the currently supported cloud providers
Expand Down
Loading