feat(tornado): Support span streaming by sl0thentr0py · Pull Request #6206 · getsentry/sentry-python

sl0thentr0py · 2026-05-05T13:32:27Z

Issues

resolves: Migrate tornado to span first #6067
resolves: PY-2369

linear-code · 2026-05-05T13:32:32Z

PY-2369 Migrate tornado to span first

github-actions · 2026-05-05T13:34:18Z

Codecov Results 📊

✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 10.05s

All tests are passing successfully.

❌ Patch coverage is 19.12%. Project has 16272 uncovered lines.

Files with missing lines (2)

File	Patch %	Lines
`tornado.py`	10.91%	⚠️ 147 Missing
`consts.py`	99.50%	⚠️ 2 Missing

Generated by Codecov Action

alexander-alderman-webb

Comment not blocking, looks good to me!

sentrivana · 2026-05-06T09:51:23Z

+                        span.status = "error" if status_int >= 400 else "ok"
+
+
+def _get_request_attributes(request: "Any") -> "Dict[str, Any]":


Are we still capturing the request body in the streaming path? See https://getsentry.github.io/sentry-conventions/attributes/http/#http-request-body-data

For prior art IIRC @ericapisani did this for another integration, not sure which exactly

starlette and aiohttp were the couple that I worked on that had this

added req body

ericapisani · 2026-05-06T12:08:49Z

+                        span.status = "error" if status_int >= 400 else "ok"
+
+
+def _get_request_attributes(request: "Any") -> "Dict[str, Any]":


starlette and aiohttp were the couple that I worked on that had this

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 1fa438a. Configure here.}

Add span-streaming support to the Tornado integration. When span streaming is enabled, the request handler emits a StreamedSpan with HTTP request attributes (method, headers, query, URL, client address) and sets the response status on completion. The legacy transaction path is preserved for non-streaming mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

ericapisani · 2026-05-15T17:14:20Z

+            scope.set_custom_sampling_context({"tornado_request": self.request})
+
+            span_ctx = sentry_sdk.traces.start_span(
+                name=_DEFAULT_TRANSACTION_NAME,


_DEFAULT_TRANSACTION_NAME is a bit strange to read in the context of streamed spans where there is no longer a "transaction".

I'm ok with either leaving this as-is until we remove the transaction v1 spans and updating this then, or doing a rename that indicates that this name is the default for a "root" span.

ericapisani · 2026-05-15T17:25:51Z

+                if isinstance(span, StreamedSpan) and not isinstance(
+                    span, NoOpStreamedSpan
+                ):


This can be made a bit more concise with type(span) is StreamedSpan:

Suggested change

if isinstance(span, StreamedSpan) and not isinstance(

span, NoOpStreamedSpan

):

if type(span) is StreamedSpan:

ericapisani · 2026-05-15T17:33:58Z

+                                span.set_attribute(
+                                    "sentry.span.source",
+                                    SegmentSource.COMPONENT,


Is there a reason why setting this attribute is being gated by whether or not a span_name exists? This looks like something that we could set regardless.

ericapisani · 2026-05-15T18:08:00Z

+    if not body:
+        return None
+
+    if not request_body_within_bounds(sentry_sdk.get_client(), len(body)):


Is the body at this point in time the "realized" result? For example, the result of request.json()?

I'm also wondering if using the content-length header - does tornado set this automatically for incoming requests?

ericapisani · 2026-05-15T18:08:47Z

-def test_transactions(tornado_testcase, sentry_init, capture_events, handler, code):
-    sentry_init(integrations=[TornadoIntegration()], traces_sample_rate=1.0)
-    events = capture_events()
+def test_transactions(


Since this is now testing both segments and transactions, this test name should be updated

sl0thentr0py requested a review from a team as a code owner May 5, 2026 13:32

sl0thentr0py changed the title ~~ref(tornado): migrate to span-first~~ ref(tornado): migrate to span first May 5, 2026

sl0thentr0py changed the title ~~ref(tornado): migrate to span first~~ feat(tornado): Support span streaming May 5, 2026

alexander-alderman-webb approved these changes May 6, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py Outdated

sentrivana reviewed May 6, 2026

View reviewed changes

ericapisani reviewed May 6, 2026

View reviewed changes

sentrivana reviewed May 7, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py

sl0thentr0py force-pushed the neel/span-first/tornado branch from 82de412 to a58538d Compare May 7, 2026 13:05

cursor Bot reviewed May 7, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py

cursor Bot reviewed May 7, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py Outdated

Comment thread sentry_sdk/integrations/tornado.py

sl0thentr0py force-pushed the neel/span-first/tornado branch from 036b60a to 4f36419 Compare May 15, 2026 12:34

sentry Bot reviewed May 15, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py Outdated

Comment thread sentry_sdk/integrations/tornado.py Outdated

cursor Bot reviewed May 15, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py

sl0thentr0py force-pushed the neel/span-first/tornado branch 3 times, most recently from 4d430e9 to 2106ec2 Compare May 15, 2026 13:06

sl0thentr0py requested review from ericapisani and sentrivana May 15, 2026 13:09

sl0thentr0py force-pushed the neel/span-first/tornado branch 3 times, most recently from e390c87 to ec6fd01 Compare May 15, 2026 13:14

sentry Bot reviewed May 15, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py Outdated

cursor Bot reviewed May 15, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py

sl0thentr0py and others added 5 commits May 15, 2026 15:52

address PR comments

9146357

req body

51f05cb

move request attrs to finally

1684e7f

bot comments

4c597a4

sl0thentr0py force-pushed the neel/span-first/tornado branch from 4d4e44e to 4c597a4 Compare May 15, 2026 13:52

sentry Bot reviewed May 15, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/tornado.py

ericapisani reviewed May 15, 2026

View reviewed changes

		span.status = "error" if status_int >= 400 else "ok"


		def _get_request_attributes(request: "Any") -> "Dict[str, Any]":

Conversation

sl0thentr0py commented May 5, 2026

Issues

Uh oh!

linear-code Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

Uh oh!

alexander-alderman-webb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented May 5, 2026 •

edited

Loading