-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat(billing-platform): add refund types + record_charge_refunds endpoint (REVENG-157) #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
armcknight
merged 11 commits into
main
from
andrewmcknight/reveng-157-protos-record-charge-refunds
Jun 12, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
83023b0
feat(billing-platform): add refund types + record_charge_refunds endp…
d0a9bc5
chore: Regenerate Rust bindings
getsantry[bot] 66c0bbb
review(billing-platform): embed refunds in PlatformCharge; drop charg…
a7befc8
Merge CI-regenerated Rust bindings into review branch
41ad2fc
review(billing-platform): rename PlatformRefund.amount to amount_cents
53dbb75
chore: Regenerate Rust bindings
getsantry[bot] 67ce9cf
review(billing-platform): drop refund-aggregate cache from PlatformCh…
1175608
chore: Regenerate Rust bindings
getsantry[bot] 7fce3ec
review(billing-platform): mark refunded/amount_refunded deprecated in…
cd1df86
Merge remote-tracking branch 'origin/andrewmcknight/reveng-157-protos…
3167124
chore: Regenerate Rust bindings
getsantry[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
proto/sentry_protos/billing/v1/services/charge/v1/endpoint_record_charge_refunds.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package sentry_protos.billing.v1.services.charge.v1; | ||
|
|
||
| import "sentry_protos/billing/v1/common/v1/stripe_charge.proto"; | ||
| import "sentry_protos/billing/v1/services/charge/v1/charge.proto"; | ||
|
|
||
| // Records platform refunds for a Stripe charge from a webhook payload. | ||
| // Mirrors the contents of ``stripe_charge.refunds`` as ``PlatformRefund`` | ||
| // rows idempotently keyed by Stripe refund id, and syncs the aggregate | ||
| // ``amount_refunded`` / ``refunded`` state on the stored ``PlatformCharge``. | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| // Called by the presentation layer that owns the ``charge.refunded`` | ||
| // webhook handler; the charge service does not call Stripe in this path | ||
| // (Stripe initiated the refund). | ||
| message RecordChargeRefundsRequest { | ||
| sentry_protos.billing.v1.common.v1.StripeCharge stripe_charge = 1; | ||
| } | ||
|
|
||
| message RecordChargeRefundsResponse { | ||
| // Unset when no platform charge exists for ``stripe_charge.id``. Callers | ||
| // use this to distinguish platform charges from legacy charges. When set, | ||
| // ``charge.refunds`` carries the platform refund rows that were recorded | ||
| // or already existed, ordered by ``date_added_st`` ascending. | ||
| optional PlatformCharge charge = 1; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.