fix(cmake): Protect CMAKE_SYSTEM_VERSION to avoid empty values when cross-building#1720
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 94fdc97. Configure here.
supervacuus
left a comment
There was a problem hiding this comment.
LGTM, Thanks! Please still add a change-log entry since this is certainly a publicly visible fix.
|
@jpnurmi, Warden fails because this is coming from a fork. No need to rerun. Warden failure is not a merge blocker. |
|
@uilianries Thanks for the fix! Could you add an entry to
|
Signed-off-by: Uilian Ries <uilianries@gmail.com>
|
@jpnurmi Done, changelog updated. Nice to see you are using keepachangelog format! 😄 |
Signed-off-by: Uilian Ries <uilianries@gmail.com>

Hello!
As explained on #1716, the missing quotes when comparing values and one is missing (
CMAKE_SYSTEM_VERSIONin this case), will fail CMake.Also, quoting the book "Professional CMake - A Practical Guide":
Professional CMake - Graig Scott, page 57 - The if() command
This PR guards
CMAKE_SYSTEM_VERSION, so if it's empty, that if condition will not break.fix #1716